coverage: remove dependency on bisect_ppx (#6807)

psafont · web-flow · commit fefe7cf26aa4 · 2025-12-17T14:21:48.000Z
This infrastructure has been unused for many years (I think it only ever
worked for some months during 2019), and it's making ocaml 5.4 difficult
to adopt, so drop it.

I'm leaving the instrumentation in the dune metadata because it's
disabled by default, and the document about coverage, because it's a
historical document.
diff --git a/Makefile b/Makefile
@@ -21,11 +21,6 @@ build:
 check:
 	dune build @check -j $(JOBS)
 
-coverage:
-	dune runtest --instrument-with bisect_ppx --force --profile=$(RELEASE) -j $(JOBS)
-	bisect-ppx-report html
-	bisect-ppx-report summary --per-file
-
 clean:
 	dune clean
 
diff --git a/dune-project b/dune-project
@@ -858,7 +858,6 @@
   (alcotest :with-test)
   astring
   base-unix
-  (bisect_ppx :with-test)
   (clock
    (and
     (= :version)
diff --git a/ocaml/libs/xapi-stdext/lib/xapi-fd-test/dune b/ocaml/libs/xapi-stdext/lib/xapi-fd-test/dune
@@ -2,7 +2,5 @@
 (library
 	(name xapi_fd_test)
 	(libraries clock (re_export xapi-stdext-unix.fdcaps) unix qcheck-core logs fmt (re_export mtime) mtime.clock.os rresult threads.posix)
-
-	; off by default, enable with --instrument-with bisect_ppx
 	(instrumentation (backend bisect_ppx))
 )
diff --git a/ocaml/libs/xapi-stdext/lib/xapi-fdcaps/dune b/ocaml/libs/xapi-stdext/lib/xapi-fdcaps/dune
@@ -5,7 +5,5 @@
 	(name xapi_fdcaps)
 	(libraries fmt unix threads.posix)
 	(flags (:standard -principal))
-
-	; off by default, enable with --instrument-with bisect_ppx
 	(instrumentation (backend bisect_ppx))
 )
diff --git a/ocaml/xapi-idl/lib/coverage/disabled.ml b/ocaml/xapi-idl/lib/coverage/disabled.ml
diff --git a/ocaml/xapi-idl/lib/coverage/enabled.ml b/ocaml/xapi-idl/lib/coverage/enabled.ml
diff --git a/ocaml/xenopsd/COVERAGE.md b/ocaml/xenopsd/COVERAGE.md
diff --git a/opam/xapi-stdext-unix.opam b/opam/xapi-stdext-unix.opam
@@ -12,7 +12,6 @@ depends: [
   "alcotest" {with-test}
   "astring"
   "base-unix"
-  "bisect_ppx" {with-test}
   "clock" {= version & with-test}
   "fd-send-recv" {>= "2.0.0"}
   "fmt"
diff --git a/quality-gate.sh b/quality-gate.sh
@@ -25,7 +25,7 @@ verify-cert () {
 }
 
 mli-files () {
-  N=459
+  N=457
   X="ocaml/tests"
   X+="|ocaml/quicktest"
   X+="|ocaml/message-switch/core_test"

Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,5 @@`
`2`	`2`	`(library`
`3`	`3`	`(name xapi_fd_test)`
`4`	`4`	`(libraries clock (re_export xapi-stdext-unix.fdcaps) unix qcheck-core logs fmt (re_export mtime) mtime.clock.os rresult threads.posix)`
`5`		`-`
`6`		`- ; off by default, enable with --instrument-with bisect_ppx`
`7`	`5`	`(instrumentation (backend bisect_ppx))`
`8`	`6`	`)`
Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,5 @@`
`5`	`5`	`(name xapi_fdcaps)`
`6`	`6`	`(libraries fmt unix threads.posix)`
`7`	`7`	`(flags (:standard -principal))`
`8`		`-`
`9`		`- ; off by default, enable with --instrument-with bisect_ppx`
`10`	`8`	`(instrumentation (backend bisect_ppx))`
`11`	`9`	`)`
Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ verify-cert () {`
`25`	`25`	`}`
`26`	`26`
`27`	`27`	`mli-files () {`
`28`		`- N=459`
	`28`	`+ N=457`
`29`	`29`	`X="ocaml/tests"`
`30`	`30`	`X+="\|ocaml/quicktest"`
`31`	`31`	`X+="\|ocaml/message-switch/core_test"`