CA-408841 rrd: don't call ds_update with an empty datasource array#6393
Conversation
|
I've tested manually and confirmed this fixes xcp-rrdd no longer working due to |
…ty datasource array
Several assumptions in the ds_update function expect at least one element to be
present in the array, and will raise Invalid_argument("index out of bounds")
otherwise. This could be triggered by disabling all datasources for a
particular plugin/owner combination, for example.
Signed-off-by: Andrii Sultanov <andrii.sultanov@cloud.com>
last-genius
force-pushed
the
private/asultanov/CA-408841
branch
from
bc4929f to
4ee32f2
Compare
|
Should I merge this? |
|
If you think it's ready :) |
|
I think @BengangY was doing more testing, so I would like to hear his opinion. |
|
I'm doing some testing on it (including manual and automatic). And I am testing if WLB, HA, SNMP, NRPE, etc all work well. |
Thank you! |
|
I have finished the testing. The fix is going well. The PR can be merged. @last-genius |
5 participants
Several assumptions in the
ds_updatefunction expect at least one element to be present in the array, and will raiseInvalid_argument("index out of bounds")otherwise. This could be triggered by disabling all datasources for a particular plugin/owner combination, for example.