CP-311260: ldaps: update design document#6978
Merged
Merged
Conversation
liulinC
commented
Mar 25, 2026
liulinC
commented
Collaborator
- Update error codes
- Current error code handing requires POOL_AUTH_ENABLE_FAILED error code prefix for enabling failed
- Replace AUTH_LDAPS_PING_FAILED to general AUTH_SET_LDAPS_FAILED and provide ldaps failed as error message
- Drop xapi configuration support
- /etc/samba/smb.extra.conf drop the xapi configure passthrough
- Log warning instead of sending warning message on ldap query failed
- It is the current behavior
- Send warning message got circle dependencies Xapi_subject->Xapi_messsage->Xapi_http->Xapi_session ->Xapi_subject This is because xapi message itself requires subject auth
lindig
approved these changes
Mar 30, 2026
- Update error codes * Current error code handing requires POOL_AUTH_ENABLE_FAILED error code prefix for enabling failed * Replace AUTH_LDAPS_PING_FAILED to general AUTH_SET_LDAPS_FAILED and provide ldaps failed as error message - Drop xapi configuration support * /etc/samba/smb.extra.conf drop the xapi configure passthrough - Log warning instead of sending warning message on ldap query failed * It is the current behavior * Send warning message got circle dependencies Xapi_subject->Xapi_messsage->Xapi_http->Xapi_session ->Xapi_subject This is because xapi message itself requires subject auth Signed-off-by: Lin Liu <lin.liu01@citrix.com>
liulinC
force-pushed
the
private/linl/dev
branch
from
ab524b3 to
02dee36
Compare
changlei-li
approved these changes
Mar 31, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.