[master] quicktests: Force VDI format on creation#6999
Merged
psafont merged 2 commits intoApr 15, 2026
Conversation
Member
|
Could you add the hashes of the cherry-picked commits, please? |
Contributor
Author
Done |
Member
I worded it incorrectly, sorry. I meant to add them in the commit messages, so they're easy to cross-check even without with this PR |
Sort of a follow-up to xapi-project#6908, which filtered out SRs that only offer QCOW2 backing files. This commit allows running delta tests on SRs that offer both QCOW2 and VHD backing files (with QCOW2 as the default). Not specifying the format on SRs with default image format=qcow2 breaks delta tests for VHD (since they require two vhd images to calculate differences between). Force the format in VDI.create through sm-config instead. The sm-config parameter is ignored if it's not supported (i.e. on XenServer VHD-only SMAPIv1 SRs). Force format=vhd for max_vdi_size tests as well, since they're only exporting to vhd (and testing its max size), this speeds up the tests. Cherry-picked from c3ac00b Signed-off-by: Andrii Sultanov <andriy.sultanov@vates.tech>
4194304 = 4MIB Cherry-picked from 68c78d8 Signed-off-by: Andrii Sultanov <andriy.sultanov@vates.tech>
last-genius
force-pushed
the
asv/master-quicktest-vhd-fix
branch
from
23f76cd to
6960404
Compare
robhoes
approved these changes
Apr 15, 2026
lindig
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
master version of #6998
cherry-picked commits 68c78d8, c3ac00b