xapi-cli-server: set name description for SRs, when given#7066
Merged
Conversation
robhoes
approved these changes
May 13, 2026
minglumlu
approved these changes
May 14, 2026
last-genius
requested changes
May 14, 2026
last-genius
left a comment
last-genius
left a comment
Contributor
There was a problem hiding this comment.
I'm wondering if we should modify xe so that we always warn that a parameter is unused? it's probably going to reveal a few missing parameters in cli_frontend, but it will make it more obvious that a command line doesn't really do what it advertises
| @@ -2606,6 +2606,7 @@ let parse_host_uuid ?(default_master = true) rpc session_id params = | |||
|
|
|||
Contributor
There was a problem hiding this comment.
You also need to modify cli_frontend.ml so that "name-description" shows up as an optional argument in the documentation.
Previously the parameter was ignored and this was confusing users that expected the parameter to be used. Signed-off-by: Pau Ruiz Safont <pau.safont@vates.tech>
psafont
force-pushed
the
dev/pau/sr-description
branch
from
ed5bcc2 to
19b0ea2
Compare
last-genius
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the parameter was ignored and this was confusing users that expected the parameter to be used.