Remove image format from deprecated receive start#7151
Queued
gthvn1 wants to merge 1 commit into
Queued
Conversation
The field image_format added to receive_start and receive_start2 breaks migration from old XAPI to new XAPI. Both are sending RPC to the destination, which runs them locally. If the destination has the field but not the source it breaks compatibility. On the other hand, receive_start3 runs on the source. It is the VDI.create that is sent remotely to the destination. This patch removes the new field. That means that you will not be able to choose the format of the destination when migrating from old version of XAPI to new version of XAPI. As receive_start and receive_start2 are deprecated the situation will become more and more rare. Signed-off-by: Guillaume Thouvenin <guillaume.thouvenin@vates.tech> (cherry picked from commit 71a2576)
changlei-li
approved these changes
Jun 29, 2026
minglumlu
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The field image_format added to receive_start and receive_start2 breaks migration from old XAPI to new XAPI.
Both are sending RPC to the destination, which runs them locally. If the destination has the field but not the source it breaks compatibility. On the other hand, receive_start3 runs on the source. It is the VDI.create that is sent remotely to the destination.
This patch removes the new field. That means that you will not be able to choose the format of the destination when migrating from old version of XAPI to new version of XAPI. As receive_start and receive_start2 are deprecated the situation will become more and more rare.
(cherry picked from commit 71a2576)