|
| 1 | +"""Regression tests for issue #1710. |
| 2 | +
|
| 3 | +A TIFF with no GeoTIFF tags (no ModelPixelScale / ModelTiepoint / |
| 4 | +GeoKeyDirectory) used to produce different `y`/`x` coordinates between |
| 5 | +full reads and windowed reads. Full reads emitted integer pixel coords |
| 6 | +``[0, 1, 2, ...]`` via the ``has_georef=False`` shortcut in |
| 7 | +``_geo_to_coords``; windowed reads bypassed that shortcut and synthesised |
| 8 | +float64 coords like ``[-0.5, -1.5, ...]`` from the default unit |
| 9 | +``GeoTransform``. |
| 10 | +
|
| 11 | +The fix routes every windowed-read path through the same shortcut, and |
| 12 | +suppresses the fabricated ``attrs['transform']`` for non-georef files. |
| 13 | +""" |
| 14 | +from __future__ import annotations |
| 15 | + |
| 16 | +import importlib.util |
| 17 | + |
| 18 | +import numpy as np |
| 19 | +import pytest |
| 20 | + |
| 21 | +from xrspatial.geotiff import open_geotiff |
| 22 | +from xrspatial.geotiff._writer import write |
| 23 | + |
| 24 | + |
| 25 | +def _gpu_available() -> bool: |
| 26 | + if importlib.util.find_spec("cupy") is None: |
| 27 | + return False |
| 28 | + try: |
| 29 | + import cupy |
| 30 | + return bool(cupy.cuda.is_available()) |
| 31 | + except Exception: |
| 32 | + return False |
| 33 | + |
| 34 | + |
| 35 | +_HAS_GPU = _gpu_available() |
| 36 | +_gpu_only = pytest.mark.skipif(not _HAS_GPU, reason="cupy + CUDA required") |
| 37 | + |
| 38 | + |
| 39 | +@pytest.fixture |
| 40 | +def no_georef_path_1710(tmp_path): |
| 41 | + """8x8 float32 TIFF with NO GeoTIFF tags (no ModelPixelScale etc.).""" |
| 42 | + arr = np.arange(64, dtype=np.float32).reshape(8, 8) |
| 43 | + path = str(tmp_path / "no_georef_1710.tif") |
| 44 | + write(arr, path, compression='none', tiled=False) |
| 45 | + return path |
| 46 | + |
| 47 | + |
| 48 | +class TestEagerWindowedCoords: |
| 49 | + |
| 50 | + def test_full_read_integer_coords(self, no_georef_path_1710): |
| 51 | + da = open_geotiff(no_georef_path_1710) |
| 52 | + assert da.y.dtype == np.int64 |
| 53 | + assert da.x.dtype == np.int64 |
| 54 | + np.testing.assert_array_equal(da.y.values, np.arange(8)) |
| 55 | + np.testing.assert_array_equal(da.x.values, np.arange(8)) |
| 56 | + |
| 57 | + def test_windowed_read_integer_coords(self, no_georef_path_1710): |
| 58 | + da = open_geotiff(no_georef_path_1710, window=(0, 0, 4, 4)) |
| 59 | + assert da.y.dtype == np.int64 |
| 60 | + assert da.x.dtype == np.int64 |
| 61 | + np.testing.assert_array_equal(da.y.values, np.arange(4)) |
| 62 | + np.testing.assert_array_equal(da.x.values, np.arange(4)) |
| 63 | + |
| 64 | + def test_offset_window_integer_coords(self, no_georef_path_1710): |
| 65 | + """Windowed read at (2, 3) origin should give coords [2,3,4,5] / [3,4,5,6].""" |
| 66 | + da = open_geotiff(no_georef_path_1710, window=(2, 3, 6, 7)) |
| 67 | + assert da.y.dtype == np.int64 |
| 68 | + assert da.x.dtype == np.int64 |
| 69 | + np.testing.assert_array_equal(da.y.values, np.arange(2, 6)) |
| 70 | + np.testing.assert_array_equal(da.x.values, np.arange(3, 7)) |
| 71 | + |
| 72 | + def test_no_transform_attr_emitted(self, no_georef_path_1710): |
| 73 | + """Non-georef files should not advertise a fabricated transform.""" |
| 74 | + da = open_geotiff(no_georef_path_1710) |
| 75 | + assert 'transform' not in da.attrs, ( |
| 76 | + f"non-georef file should not carry a fabricated transform; " |
| 77 | + f"got attrs={dict(da.attrs)}" |
| 78 | + ) |
| 79 | + # Same for windowed read |
| 80 | + da_w = open_geotiff(no_georef_path_1710, window=(0, 0, 4, 4)) |
| 81 | + assert 'transform' not in da_w.attrs |
| 82 | + |
| 83 | + |
| 84 | +class TestDaskWindowedCoords: |
| 85 | + |
| 86 | + def test_full_read_integer_coords(self, no_georef_path_1710): |
| 87 | + da = open_geotiff(no_georef_path_1710, chunks=4) |
| 88 | + assert da.y.dtype == np.int64 |
| 89 | + np.testing.assert_array_equal(da.y.values, np.arange(8)) |
| 90 | + |
| 91 | + def test_windowed_read_integer_coords(self, no_georef_path_1710): |
| 92 | + da = open_geotiff(no_georef_path_1710, chunks=4, window=(0, 0, 4, 4)) |
| 93 | + assert da.y.dtype == np.int64 |
| 94 | + np.testing.assert_array_equal(da.y.values, np.arange(4)) |
| 95 | + |
| 96 | + def test_offset_window_integer_coords(self, no_georef_path_1710): |
| 97 | + da = open_geotiff(no_georef_path_1710, chunks=4, window=(2, 3, 6, 7)) |
| 98 | + assert da.y.dtype == np.int64 |
| 99 | + np.testing.assert_array_equal(da.y.values, np.arange(2, 6)) |
| 100 | + np.testing.assert_array_equal(da.x.values, np.arange(3, 7)) |
| 101 | + |
| 102 | + |
| 103 | +@_gpu_only |
| 104 | +class TestGpuWindowedCoords: |
| 105 | + |
| 106 | + def test_full_read_integer_coords(self, no_georef_path_1710): |
| 107 | + da = open_geotiff(no_georef_path_1710, gpu=True) |
| 108 | + assert da.y.dtype == np.int64 |
| 109 | + np.testing.assert_array_equal(da.y.values, np.arange(8)) |
| 110 | + |
| 111 | + def test_windowed_read_integer_coords(self, no_georef_path_1710): |
| 112 | + da = open_geotiff(no_georef_path_1710, gpu=True, window=(0, 0, 4, 4)) |
| 113 | + assert da.y.dtype == np.int64 |
| 114 | + np.testing.assert_array_equal(da.y.values, np.arange(4)) |
| 115 | + |
| 116 | + def test_dask_cupy_windowed_integer_coords(self, no_georef_path_1710): |
| 117 | + da = open_geotiff(no_georef_path_1710, gpu=True, chunks=4, |
| 118 | + window=(0, 0, 4, 4)) |
| 119 | + assert da.y.dtype == np.int64 |
| 120 | + np.testing.assert_array_equal(da.y.values, np.arange(4)) |
| 121 | + |
| 122 | + |
| 123 | +class TestBackendParity: |
| 124 | + """Full read and windowed read must agree on coord dtype and values |
| 125 | + across every backend pair.""" |
| 126 | + |
| 127 | + def test_dtype_parity_full(self, no_georef_path_1710): |
| 128 | + np_da = open_geotiff(no_georef_path_1710) |
| 129 | + dk_da = open_geotiff(no_georef_path_1710, chunks=4) |
| 130 | + assert np_da.y.dtype == dk_da.y.dtype == np.int64 |
| 131 | + if _HAS_GPU: |
| 132 | + gpu_da = open_geotiff(no_georef_path_1710, gpu=True) |
| 133 | + assert gpu_da.y.dtype == np.int64 |
| 134 | + |
| 135 | + def test_dtype_parity_windowed(self, no_georef_path_1710): |
| 136 | + win = (0, 0, 4, 4) |
| 137 | + np_da = open_geotiff(no_georef_path_1710, window=win) |
| 138 | + dk_da = open_geotiff(no_georef_path_1710, chunks=4, window=win) |
| 139 | + assert np_da.y.dtype == dk_da.y.dtype == np.int64 |
| 140 | + if _HAS_GPU: |
| 141 | + gpu_da = open_geotiff(no_georef_path_1710, gpu=True, window=win) |
| 142 | + assert gpu_da.y.dtype == np.int64 |
| 143 | + |
| 144 | + def test_full_and_windowed_first_n_match(self, no_georef_path_1710): |
| 145 | + """Coords for a window starting at (0, 0) should equal the first N |
| 146 | + coords of the full read.""" |
| 147 | + win = (0, 0, 4, 4) |
| 148 | + full = open_geotiff(no_georef_path_1710) |
| 149 | + win_da = open_geotiff(no_georef_path_1710, window=win) |
| 150 | + np.testing.assert_array_equal(full.y.values[:4], win_da.y.values) |
| 151 | + np.testing.assert_array_equal(full.x.values[:4], win_da.x.values) |
| 152 | + |
| 153 | + |
| 154 | +class TestGeorefStillWorks: |
| 155 | + """The fix must not regress georeferenced reads. |
| 156 | +
|
| 157 | + Files with real GeoTIFF tags still get float64 coords with the |
| 158 | + half-pixel shift for PixelIsArea. |
| 159 | + """ |
| 160 | + |
| 161 | + def test_georef_full_read_keeps_float64(self, tmp_path): |
| 162 | + from xrspatial.geotiff._geotags import GeoTransform |
| 163 | + arr = np.arange(64, dtype=np.float32).reshape(8, 8) |
| 164 | + gt = GeoTransform( |
| 165 | + origin_x=500000.0, origin_y=4000000.0, |
| 166 | + pixel_width=30.0, pixel_height=-30.0, |
| 167 | + ) |
| 168 | + path = str(tmp_path / "georef_1710.tif") |
| 169 | + write(arr, path, geo_transform=gt, crs_epsg=32610, |
| 170 | + compression='none', tiled=False) |
| 171 | + da = open_geotiff(path) |
| 172 | + assert da.y.dtype == np.float64 |
| 173 | + assert da.x.dtype == np.float64 |
| 174 | + assert da.x.values[0] == pytest.approx(500015.0) |
| 175 | + # transform attr SHOULD be present for georef files |
| 176 | + assert 'transform' in da.attrs |
| 177 | + |
| 178 | + def test_georef_windowed_read_keeps_float64(self, tmp_path): |
| 179 | + from xrspatial.geotiff._geotags import GeoTransform |
| 180 | + arr = np.arange(64, dtype=np.float32).reshape(8, 8) |
| 181 | + gt = GeoTransform( |
| 182 | + origin_x=500000.0, origin_y=4000000.0, |
| 183 | + pixel_width=30.0, pixel_height=-30.0, |
| 184 | + ) |
| 185 | + path = str(tmp_path / "georef_win_1710.tif") |
| 186 | + write(arr, path, geo_transform=gt, crs_epsg=32610, |
| 187 | + compression='none', tiled=False) |
| 188 | + da = open_geotiff(path, window=(0, 0, 4, 4)) |
| 189 | + assert da.y.dtype == np.float64 |
| 190 | + assert da.x.dtype == np.float64 |
| 191 | + assert 'transform' in da.attrs |
0 commit comments