Skip to content

Debug: print copilot-review gate inputs#1592

Merged
brendancol merged 1 commit into
mainfrom
debug-copilot-review-if
May 11, 2026
Merged

Debug: print copilot-review gate inputs#1592
brendancol merged 1 commit into
mainfrom
debug-copilot-review-if

Conversation

@brendancol
Copy link
Copy Markdown
Contributor

Summary

  • Adds an unconditional debug-event job to .github/workflows/copilot-review.yml that prints action, draft, author_association, user.login, and head/base repo on every pull_request_target event.

Why

The request-copilot-review job has been silently skipped on every PR since the workflow landed (e.g. #1589, plus the next maintainer PR after it). The REST view of those PRs shows draft: false and author_association: "MEMBER", which should satisfy the gate, so the event payload likely contains a different value at trigger time. The debug job will surface that value once any PR fires the workflow.

Test plan

  • After this PR is open, check the debug-event job logs and confirm what assoc actually is at event time
  • Once diagnosed, fix the if: condition (or drop the author_association gate) and remove the debug job

Prints draft, author_association, and event action on every PR to
diagnose why the request-copilot-review gate is evaluating to false
on maintainer PRs (e.g. #1589). Remove once the gate is fixed.
@github-actions github-actions Bot added the performance PR touches performance-sensitive code label May 11, 2026
@brendancol brendancol merged commit b50e7f5 into main May 11, 2026
7 of 11 checks passed
@brendancol brendancol deleted the debug-copilot-review-if branch May 11, 2026 15:03
brendancol added a commit that referenced this pull request May 11, 2026
The pull_request_target event payload reports author_association as
CONTRIBUTOR for org members on same-repo branches (confirmed via the
debug-event job added in #1592 and fired by #1593), so the previous
gate filtered out every maintainer PR.

Switch to head.repo.full_name == base.repo.full_name. Same-repo PRs
require push access to the base repo, which is the maintainer signal
we actually want. Fork PRs (where the maintainer cannot push to base)
remain excluded.

Also removes the now-unneeded debug-event job.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance PR touches performance-sensitive code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant