Skip to content

Fix Windows tempdir cleanup race in test_vrt_tiled_scheduler_1714 #1748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brendancol merged 1 commit into from
May 12, 2026
+12 −4
Merged

Fix Windows tempdir cleanup race in test_vrt_tiled_scheduler_1714 #1748

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions xrspatial/geotiff/tests/test_vrt_tiled_scheduler_1714.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,9 @@ def _make_dask_da(h: int = 32, w: int = 32, chunk: int = 8) -> xr.DataArray:
def test_vrt_tiled_uses_threaded_scheduler():
"""_write_vrt_tiled passes ``scheduler='threads'`` to dask.compute."""
da_arr = _make_dask_da()
with tempfile.TemporaryDirectory(prefix="vrt_sched_1714_") as td:
with tempfile.TemporaryDirectory(
prefix="vrt_sched_1714_", ignore_cleanup_errors=True
) as td:
vrt = os.path.join(td, "sched_check.vrt")

# Wrap dask.compute so we can record the scheduler kwarg the
Expand All @@ -67,7 +69,9 @@ def spy(*args, **kwargs):
def test_vrt_tiled_threaded_write_produces_all_tiles():
"""All expected tile files exist after the threaded write."""
da_arr = _make_dask_da(h=32, w=32, chunk=8) # 4x4 = 16 tiles
with tempfile.TemporaryDirectory(prefix="vrt_sched_1714_") as td:
with tempfile.TemporaryDirectory(
prefix="vrt_sched_1714_", ignore_cleanup_errors=True
) as td:
vrt = os.path.join(td, "tile_count.vrt")
to_geotiff(da_arr, vrt)
tiles_dir = os.path.join(td, "tile_count_tiles")
Expand Down Expand Up @@ -95,8 +99,12 @@ def _write_and_collect(vrt_path: str) -> dict[str, bytes]:
for p in sorted(glob.glob(os.path.join(tiles_dir, "*.tif")))
}

with tempfile.TemporaryDirectory(prefix="vrt_sched_1714_") as td1:
with tempfile.TemporaryDirectory(prefix="vrt_sched_1714_") as td2:
with tempfile.TemporaryDirectory(
prefix="vrt_sched_1714_", ignore_cleanup_errors=True
) as td1:
with tempfile.TemporaryDirectory(
prefix="vrt_sched_1714_", ignore_cleanup_errors=True
) as td2:
tiles1 = _write_and_collect(os.path.join(td1, "run1.vrt"))
tiles2 = _write_and_collect(os.path.join(td2, "run2.vrt"))

Expand Down
Loading