Fix support for numpy<2.0 and pearson_r with numpy>2.0#431
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #431 +/- ##
=======================================
Coverage 94.55% 94.56%
=======================================
Files 27 27
Lines 2829 2833 +4
=======================================
+ Hits 2675 2679 +4
Misses 154 154 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aaronspring
approved these changes
Jul 18, 2025
Collaborator
|
Sorry. Merging was premature |
Collaborator
Author
|
I can start a PR just to update the changelog, if that works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fix deals with an oversight in the last release that accidentally dropped support for numpy v1. It also fixes a very small bug that can occur in numpy v2.0+, where a single value Pearson R (non-
np.ndarray) can cause aValueError.Closes #430
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Tested locally with numpy v1.26 (should work fine with numpy v1.24) and numpy v2.0.
Pre-Merge Checklist (final steps)
References