Fix doctests by reordering coordinates in expected outputs#436
Closed
Copilot wants to merge 2 commits into
Closed
Conversation
Collaborator
|
@copilot continue |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## aaronspring-patch-1 #436 +/- ##
======================================================
Coverage ? 94.55%
======================================================
Files ? 27
Lines ? 2830
Branches ? 0
======================================================
Hits ? 2676
Misses ? 154
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: aaronspring <12237157+aaronspring@users.noreply.github.com>
Author
Fixed the doctest failures. The issue was that coordinate ordering in xarray outputs had changed. I reordered the coordinates in the expected outputs for two functions:
All 32 doctests now pass. Commit: d9ec2d4 |
Copilot
AI
changed the title
[WIP] Fix doctests by reordering test cases for correctness
Fix doctests by reordering coordinates in expected outputs
Oct 11, 2025
Collaborator
|
Nice. But did manually quicker. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes doctest failures in the repository by correcting the coordinate ordering in expected outputs to match the actual xarray behavior.
Issue Identified
Two doctest failures were found:
xskillscore.core.probabilistic.discrimination- coordinate ordering mismatchxskillscore.core.stattests.multipletests- coordinate ordering mismatchThe issue was caused by xarray's coordinate ordering in outputs, which differs from what was documented in the expected test outputs.
Changes Made
forecast_probability, eventtoevent, forecast_probabilityx, y, resulttoresult, x, yVerification
This fix addresses issue #435.
Original prompt
This pull request was created as a result of the following prompt from Copilot chat.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.