Merged
Conversation
This PR completes the fixes started in PR #435 by removing all remaining np.atleast_1d() calls that were causing numerical differences in p-value calculations with NumPy 2.x. Changes: - Remove np.atleast_1d() from _effective_sample_size (line 146) - Remove np.atleast_1d() from _pearson_r_p_value (line 350) - Simplify NaN handling in _pearson_r_p_value using np.where() - Simplify NaN handling in _pearson_r_eff_p_value using np.where() - Remove np.atleast_1d() from _spearman_r_p_value (line 483) These changes ensure that p-value calculations return the same numerical results with NumPy 2.x as they did with NumPy 1.x, fixing doctest failures in downstream packages like climpred. Fixes numerical regression introduced in v0.0.27. Completes #435 Related to pangeo-data/climpred#870 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Fix discrimination doctest coordinate order by enforcing consistent ordering - Suppress NumPy scalar conversion warnings in multipletests - Update pearson_r_eff_p_value doctest to reflect behavior change from #437 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Remove duplicate result coordinate definition in stattests.py
The PR incorrectly changed two doctest expectations: 1. In pearson_r_eff_p_value, the expected value at [2,2] was changed from 'nan' to '1.', but the actual output is still 'nan' after removing np.atleast_1d() calls. 2. In multipletests, the coordinate order was changed, but the actual output has 'result' coordinate last, not first. This commit fixes both doctest expectations to match the actual output, resolving CI test failures. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This reverts commit 4ef1286.
The discrimination function was incorrectly always returning a DataArray, even when the input was a Dataset. This caused test failures where: - Dataset inputs returned DataArray outputs (type mismatch) - Using .values on Dataset returned bound methods instead of data Changes: - Add type checking to preserve input type (Dataset vs DataArray) - Use .data instead of .values to preserve dask arrays - Return Dataset as-is without reconstruction when input is Dataset Fixes test_discrimination_sum failures across all Python versions. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #440 +/- ##
==========================================
- Coverage 94.56% 94.56% -0.01%
==========================================
Files 27 27
Lines 2833 2832 -1
==========================================
- Hits 2679 2678 -1
Misses 154 154 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aaronspring
commented
Oct 15, 2025
| array([[0.82544245, nan, 0.25734167], | ||
| [0.78902959, 0.57503354, 0.8059353 ], | ||
| [0.79242625, 0.66792245, nan]]) | ||
| [0.79242625, 0.66792245, 1. ]]) |
Collaborator
Author
There was a problem hiding this comment.
need to deep dive
Collaborator
Author
There was a problem hiding this comment.
dont see a problem here. random data input anyways
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think we should go with this PR @Zeitsperre. CI passing