Add replica identity check#911
Merged
Merged
Conversation
17 tasks
Collaborator
Author
|
@copilot resolve the merge conflicts in this pull request |
Contributor
Resolved the merge conflicts in this PR in commit |
c961994 to
4542409
Compare
17 tasks
96f62ee to
dcd631d
Compare
exekias
approved these changes
Jun 29, 2026
kvch
added a commit
that referenced
this pull request
Jun 29, 2026
#### Description This PR adds a new `stream.TableSelection` struct to hold included and excluded tables. This can be used to check if a table is included in streaming. ```go // Package-level constructor func NewTableSelection(include, exclude []string) (TableSelection, error) // Methods on TableSelection func (s TableSelection) IsUnfiltered() bool func (s TableSelection) IsTableInScope(schema, table string) bool func (s TableSelection) Include() []string func (s TableSelection) Exclude() []string ``` From now on, incorrect include and exclude configurations return errors instead of silently ignoring the setting. This change is required by #911 #### Type of Change Please select the relevant option(s): - [x] 🐛 Bug fix (non-breaking change that fixes an issue) - [ ] ✨ New feature (non-breaking change that adds functionality) - [ ] 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] 📚 Documentation update - [x] 🔧 Refactoring (no functional changes) - [ ] ⚡ Performance improvement - [ ] 🧪 Test coverage improvement - [ ] 🔨 Build/CI changes - [ ] 🧹 Code cleanup #### Testing - [x] Unit tests added/updated - [x] Integration tests added/updated - [x] Manual testing performed - [x] All existing tests pass #### Checklist - [x] Code follows project style guidelines - [x] Self-review completed - [x] Code is well-commented - [x] Documentation updated where necessary --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Base automatically changed from
feature-config-validate-table-selections
to
main
June 29, 2026 13:52
Collaborator
Author
|
@copilot resolve the merge conflicts in this pull request |
Contributor
Resolved the merge conflicts in commit |
Merging this branch will decrease overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new replication check for making sure replicate identity is configured correctly for replicating updates and deletes.
Example output
Correct settings
Incorrect settings
Related Issue(s)
pgstream checkcommand for pre-migration sanity checks #897Type of Change
Please select the relevant option(s):
Testing
Checklist
Additional Notes