Skip to content
Merged

Dev #40

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 22 additions & 22 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ This project is not implementing analysis by itself, it is using existing analys


**Note that before version 2.1.0 the AnalysisLevel property was set to "latest" resulting in breaking the build just on framework update.**
**So from version 2.1.0 the analysis level is fixed to a specific version (currently 10.0 with version 3.0.0)**
**So from version 2.1.0 the analysis level is fixed to a specific version (currently 10.0 from version 3.0.0)**

* * *

Expand All @@ -57,26 +57,26 @@ You can checkout this Github repository or you can use the NuGet package:

**Install using the command line from the Package Manager:**
```bash
Install-Package SoloX.CodeQuality.Prod -version 3.0.0
Install-Package SoloX.CodeQuality.Prod -version 3.0.1-preview.1
or
Install-Package SoloX.CodeQuality.Test -version 3.0.0
Install-Package SoloX.CodeQuality.Test -version 3.0.1-preview.1
```

**Install using the .Net CLI:**
```bash
dotnet add package SoloX.CodeQuality.Prod --version 3.0.0
dotnet add package SoloX.CodeQuality.Prod --version 3.0.1-preview.1
or
dotnet add package SoloX.CodeQuality.Test --version 3.0.0
dotnet add package SoloX.CodeQuality.Test --version 3.0.1-preview.1
```

**Install editing your project file (csproj):**
```xml
<PackageReference Include="SoloX.CodeQuality.Prod" Version="3.0.0">
<PackageReference Include="SoloX.CodeQuality.Prod" Version="3.0.1-preview.1">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
</PackageReference>
or
<PackageReference Include="SoloX.CodeQuality.Test" Version="3.0.0">
<PackageReference Include="SoloX.CodeQuality.Test" Version="3.0.1-preview.1">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
</PackageReference>
Expand Down Expand Up @@ -223,17 +223,17 @@ You can checkout this Github repository or use the NuGet package:

**Install using the command line from the Package Manager:**
```bash
Install-Package SoloX.CodeQuality.Playwright -version 3.0.0
Install-Package SoloX.CodeQuality.Playwright -version 3.0.1-preview.1
```

**Install using the .Net CLI:**
```bash
dotnet add package SoloX.CodeQuality.Playwright --version 3.0.0
dotnet add package SoloX.CodeQuality.Playwright --version 3.0.1-preview.1
```

**Install editing your project file (csproj):**
```xml
<PackageReference Include="SoloX.CodeQuality.Playwright" Version="3.0.0" />
<PackageReference Include="SoloX.CodeQuality.Playwright" Version="3.0.1-preview.1" />
```

* * *
Expand Down Expand Up @@ -429,35 +429,35 @@ You can checkout this Github repository or you can use the NuGet package:

**Install using the command line from the Package Manager:**
```bash
Install-Package SoloX.CodeQuality.Test.Helpers -version 3.0.0
Install-Package SoloX.CodeQuality.Test.Helpers -version 3.0.1-preview.1

Install-Package SoloX.CodeQuality.Test.Helpers.XUnit -version 3.0.0
Install-Package SoloX.CodeQuality.Test.Helpers.XUnit -version 3.0.1-preview.1

Install-Package SoloX.CodeQuality.Test.Helpers.XUnit.V3 -version 3.0.0
Install-Package SoloX.CodeQuality.Test.Helpers.XUnit.V3 -version 3.0.1-preview.1

Install-Package SoloX.CodeQuality.Test.Helpers.NUnit -version 3.0.0
Install-Package SoloX.CodeQuality.Test.Helpers.NUnit -version 3.0.1-preview.1
```

**Install using the .Net CLI:**
```bash
dotnet add package SoloX.CodeQuality.Test.Helpers --version 3.0.0
dotnet add package SoloX.CodeQuality.Test.Helpers --version 3.0.1-preview.1

dotnet add package SoloX.CodeQuality.Test.Helpers.XUnit --version 3.0.0
dotnet add package SoloX.CodeQuality.Test.Helpers.XUnit --version 3.0.1-preview.1

dotnet add package SoloX.CodeQuality.Test.Helpers.XUnit.V3 --version 3.0.0
dotnet add package SoloX.CodeQuality.Test.Helpers.XUnit.V3 --version 3.0.1-preview.1

dotnet add package SoloX.CodeQuality.Test.Helpers.NUnit --version 3.0.0
dotnet add package SoloX.CodeQuality.Test.Helpers.NUnit --version 3.0.1-preview.1
```

**Install editing your project file (csproj):**
```xml
<PackageReference Include="SoloX.CodeQuality.Test.Helpers" Version="3.0.0" />
<PackageReference Include="SoloX.CodeQuality.Test.Helpers" Version="3.0.1-preview.1" />

<PackageReference Include="SoloX.CodeQuality.Test.Helpers.XUnit" Version="3.0.0" />
<PackageReference Include="SoloX.CodeQuality.Test.Helpers.XUnit" Version="3.0.1-preview.1" />

<PackageReference Include="SoloX.CodeQuality.Test.Helpers.XUnit.V3" Version="3.0.0" />
<PackageReference Include="SoloX.CodeQuality.Test.Helpers.XUnit.V3" Version="3.0.1-preview.1" />

<PackageReference Include="SoloX.CodeQuality.Test.Helpers.NUnit" Version="3.0.0" />
<PackageReference Include="SoloX.CodeQuality.Test.Helpers.NUnit" Version="3.0.1-preview.1" />
```

* * *
Expand Down
4 changes: 2 additions & 2 deletions src/SharedProperties.props
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project>

<PropertyGroup>
<Version>3.0.0</Version>
<Version>3.0.1-preview.1</Version>
<Authors>Xavier Solau</Authors>
<Copyright>Copyright © 2021-2026 Xavier Solau</Copyright>
<PackageLicenseExpression>MIT</PackageLicenseExpression>
Expand All @@ -14,7 +14,7 @@
<CodeQualityHeaderLicense>$(PackageLicenseExpression)</CodeQualityHeaderLicense>
<CodeQualityHeaderLicenseFile>LICENSE</CodeQualityHeaderLicenseFile>

<AssemblyVersion>3.0.0.0</AssemblyVersion>
<AssemblyVersion>3.0.1.0</AssemblyVersion>
<LangVersion>14</LangVersion>

</PropertyGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.Playwright" Version="1.58.0" />
<PackageReference Include="Microsoft.Playwright" Version="1.59.0" />
</ItemGroup>

<ItemGroup Condition=" '$(TargetFramework)' == 'net8.0' ">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,6 @@ dotnet_diagnostic.CS0168.severity = error

# CS8603: Possible null reference return.
dotnet_diagnostic.CS8603.severity = error

# CS8604 Possible null reference argument.
dotnet_diagnostic.CS8604.severity = error
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
</ItemGroup>

<ItemGroup Condition="'$(TargetFramework)' == 'net10.0'">
<PackageReference Include="Microsoft.Build" Version="18.3.3" />
<PackageReference Include="Microsoft.Build" Version="18.4.0" />
</ItemGroup>

<ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,7 @@ dotnet_diagnostic.CA2009.severity = error
dotnet_diagnostic.CA2011.severity = error

# CA2012: Utilisez correctement ValueTasks
dotnet_diagnostic.CA2012.severity = error
dotnet_diagnostic.CA2012.severity = warning

# CA2013: Ne pas utiliser ReferenceEquals avec des types valeur
dotnet_diagnostic.CA2013.severity = error
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,11 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="coverlet.collector" Version="8.0.0" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.3.0" />
<PackageReference Include="coverlet.collector" Version="10.0.0">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.5.1" />
<PackageReference Include="xunit" Version="2.9.3" />
<PackageReference Include="xunit.runner.visualstudio" Version="3.1.5" />
<PackageReference Include="Shouldly" Version="4.3.0" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,11 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="10.0.0" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.3.0" />
<PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="10.0.7" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.5.1" />
<PackageReference Include="NUnit" Version="4.5.1" />
<PackageReference Include="NUnit3TestAdapter" Version="6.1.0" />
<PackageReference Include="coverlet.collector" Version="8.0.0">
<PackageReference Include="NUnit3TestAdapter" Version="6.2.0" />
<PackageReference Include="coverlet.collector" Version="10.0.0">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ public async Task SaveShouldHandleStreamWithPosition()

File.Exists(filePath).ShouldBeTrue();

await stream.DisposeAsync().ConfigureAwait(false);
await stream.DisposeAsync();
}

[Fact]
Expand All @@ -145,7 +145,7 @@ public async Task SaveShouldThrowForNonSeekableStream()
mockStream.Position = 5; // Position > 0

await Should.ThrowAsync<InvalidOperationException>(
() => strategy.SaveAsync(filePath, mockStream)).ConfigureAwait(false);
() => strategy.SaveAsync(filePath, mockStream));
}

[Fact]
Expand Down Expand Up @@ -181,12 +181,12 @@ public async Task CompareShouldDetectIdenticalImages()
data2.SaveTo(compareStream);
compareStream.Seek(0, SeekOrigin.Begin);

var result = await strategy.CompareAsync(referenceFilePath, compareStream).ConfigureAwait(false);
var result = await strategy.CompareAsync(referenceFilePath, compareStream);

result.IsDifferent.ShouldBeFalse();
result.DiffsData.ShouldBeNull();

await compareStream.DisposeAsync().ConfigureAwait(false);
await compareStream.DisposeAsync();
}
}

Expand Down Expand Up @@ -223,16 +223,16 @@ public async Task CompareShouldDetectDifferentImages()
data2.SaveTo(compareStream);
compareStream.Seek(0, SeekOrigin.Begin);

var result = await strategy.CompareAsync(referenceFilePath, compareStream).ConfigureAwait(false);
var result = await strategy.CompareAsync(referenceFilePath, compareStream);

result.IsDifferent.ShouldBeTrue();
result.DiffsData.ShouldNotBeNull();
result.DiffsString.ShouldContain("See Png Diffs file");

await compareStream.DisposeAsync().ConfigureAwait(false);
await compareStream.DisposeAsync();
if (result.DiffsData is not null)
{
await result.DiffsData.DisposeAsync().ConfigureAwait(false);
await result.DiffsData.DisposeAsync();
}
}
}
Expand Down Expand Up @@ -270,15 +270,15 @@ public async Task CompareShouldDetectImageSizeDifferences()
data2.SaveTo(compareStream);
compareStream.Seek(0, SeekOrigin.Begin);

var result = await strategy.CompareAsync(referenceFilePath, compareStream).ConfigureAwait(false);
var result = await strategy.CompareAsync(referenceFilePath, compareStream);

result.IsDifferent.ShouldBeTrue();
result.DiffsData.ShouldNotBeNull();

await compareStream.DisposeAsync().ConfigureAwait(false);
await compareStream.DisposeAsync();
if (result.DiffsData is not null)
{
await result.DiffsData.DisposeAsync().ConfigureAwait(false);
await result.DiffsData.DisposeAsync();
}
}
}
Expand Down Expand Up @@ -318,14 +318,14 @@ public async Task CompareShouldRespectDifferencesThreshold()
data2.SaveTo(compareStream);
compareStream.Seek(0, SeekOrigin.Begin);

var result = await strategy.CompareAsync(referenceFilePath, compareStream).ConfigureAwait(false);
var result = await strategy.CompareAsync(referenceFilePath, compareStream);

result.DiffsString.ShouldContain("See Png Diffs file");

await compareStream.DisposeAsync().ConfigureAwait(false);
await compareStream.DisposeAsync();
if (result.DiffsData is not null)
{
await result.DiffsData.DisposeAsync().ConfigureAwait(false);
await result.DiffsData.DisposeAsync();
}
}
}
Expand Down Expand Up @@ -363,16 +363,16 @@ public async Task CompareShouldReturnDiffImageStream()
data2.SaveTo(compareStream);
compareStream.Seek(0, SeekOrigin.Begin);

var result = await strategy.CompareAsync(referenceFilePath, compareStream).ConfigureAwait(false);
var result = await strategy.CompareAsync(referenceFilePath, compareStream);

result.DiffsData.ShouldNotBeNull();
result.DiffsData.Position.ShouldBe(0);
result.DiffsData.Length.ShouldBeGreaterThan(0);

await compareStream.DisposeAsync().ConfigureAwait(false);
await compareStream.DisposeAsync();
if (result.DiffsData is not null)
{
await result.DiffsData.DisposeAsync().ConfigureAwait(false);
await result.DiffsData.DisposeAsync();
}
}
}
Expand Down Expand Up @@ -409,11 +409,11 @@ public async Task CompareShouldHandleStreamAtPosition()
var compareStream = new MemoryStream();
data2.SaveTo(compareStream);

var result = await strategy.CompareAsync(referenceFilePath, compareStream).ConfigureAwait(false);
var result = await strategy.CompareAsync(referenceFilePath, compareStream);

result.IsDifferent.ShouldBeFalse();

await compareStream.DisposeAsync().ConfigureAwait(false);
await compareStream.DisposeAsync();
}
}

Expand Down Expand Up @@ -450,14 +450,14 @@ public async Task CompareShouldReturnDiffsStringWithThresholdInfo()
data2.SaveTo(compareStream);
compareStream.Seek(0, SeekOrigin.Begin);

var result = await strategy.CompareAsync(referenceFilePath, compareStream).ConfigureAwait(false);
var result = await strategy.CompareAsync(referenceFilePath, compareStream);

result.DiffsString.ShouldContain("threshold 0.3");

await compareStream.DisposeAsync().ConfigureAwait(false);
await compareStream.DisposeAsync();
if (result.DiffsData is not null)
{
await result.DiffsData.DisposeAsync().ConfigureAwait(false);
await result.DiffsData.DisposeAsync();
}
}
}
Expand Down Expand Up @@ -495,11 +495,11 @@ public async Task CompareShouldHandleZeroThreshold()
data2.SaveTo(compareStream);
compareStream.Seek(0, SeekOrigin.Begin);

var result = await strategy.CompareAsync(referenceFilePath, compareStream).ConfigureAwait(false);
var result = await strategy.CompareAsync(referenceFilePath, compareStream);

result.IsDifferent.ShouldBeFalse();

await compareStream.DisposeAsync().ConfigureAwait(false);
await compareStream.DisposeAsync();
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,11 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="coverlet.collector" Version="8.0.0" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.3.0" />
<PackageReference Include="coverlet.collector" Version="10.0.0">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.5.1" />
<PackageReference Include="xunit" Version="2.9.3" />
<PackageReference Include="xunit.runner.visualstudio" Version="3.1.5" />
<PackageReference Include="Shouldly" Version="4.3.0" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,14 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="coverlet.collector" Version="8.0.0" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.3.0" />
<PackageReference Include="coverlet.collector" Version="10.0.0">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.5.1" />
<PackageReference Include="xunit" Version="2.9.3" />
<PackageReference Include="xunit.runner.visualstudio" Version="3.1.5" />
<PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="10.0.0" />
<PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="10.0.7" />
</ItemGroup>

<ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,14 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="coverlet.collector" Version="8.0.0" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.3.0" />
<PackageReference Include="coverlet.collector" Version="10.0.0">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.5.1" />
<PackageReference Include="xunit.v3" Version="3.2.2" />
<PackageReference Include="xunit.runner.visualstudio" Version="3.1.5" />
<PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="10.0.0" />
<PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="10.0.7" />
</ItemGroup>

<ItemGroup>
Expand Down
Loading