Skip to content

[depends][bento4] Version bump 1.6.0-641-6-Piers#2080

Merged
CastagnaIT merged 1 commit into
xbmc:Piersfrom
CastagnaIT:dep_bento
Jun 28, 2026
Merged

[depends][bento4] Version bump 1.6.0-641-6-Piers#2080
CastagnaIT merged 1 commit into
xbmc:Piersfrom
CastagnaIT:dep_bento

Conversation

@CastagnaIT

@CastagnaIT CastagnaIT commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Description

Sync bento4 sources to upstream master branch

that includes:

ref. https://github.com/xbmc/Bento4/tree/release/v1.6.0-641-5-kodi

Motivation and context

fix #2015

How has this been tested?

tested on android / windows with/without drm

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • I have read the Contributing document
  • My code follows the Code Guidelines of this project
  • My change requires a change to the Wiki documentation
  • I have updated the documentation accordingly

@CastagnaIT CastagnaIT added Type: Improvement non-breaking change which improves existing functionality Component: Depends v22 Piers labels Jun 25, 2026
@kodiai

kodiai Bot commented Jun 25, 2026

Copy link
Copy Markdown

Decision: APPROVE

Issues: none

Evidence:

  • Review prompt covered 2 changed files.
Review Details
  • Review plan: ready hash=d708c0e40198 route=tiny-diff task=review.small-diff files=2 lines=4(local-diff) budget=na/671s gates=3/3 publish=canonical-visible-surface graph=skipped candidates=preferred doctrine=disabled/0/0/0 reasons=disabled

  • Review reducer: ready input=1 kept=1 suppressed=0 rewritten=0 deprioritized=0 lowConfidence=0 auditEvents=0 severityDemoted=0 graphValidated=0 graphUncertain=0 doctrine=disabled/0/0/0 reasons=disabled

  • Review candidates: shadow recorded=1 rejected=0 errors=0 artifact=present repo=xbmc-inputstream.adaptive pr=2080 key=kodiai-review-output:v1:inst-109141824:xbmc-inputstream.adaptive:pr-2080:action- delivery=458e58e0-7099-11f1-9e87-0d09274232ce

  • Review candidate publication: mode=blocked approved=1 rewritten=0 publishable=0 nonPublishable=1 fixBlocked=1 published=0 directFallback=0 reasons=fix-eligibility-blocked movedToDetails=0 detailsOmitted=0 buckets=blocked:1:fix-eligibility-blocked+missing-replacement

  • M072 candidate publication bridge: status=denied; bridgeVersion=candidate-publication-bridge.v1; bridgeId=candidate-publication-record:093ca78af12e0f7c4f1b6575a6df6ddd; recordKey=candidate-publication-record:093ca78af12e0f7c4f1b6575a6df6ddd; correlationKey=candidate-publication-bridge:85a0be4749d7a2b196538bf74c3ea7b9; source=review-handler-publication; candidateRef=candidate-publication-summary-3c0462ce; verification=none; counts=candidateCount:0,evidenceCount:0,verifiedCount:0,partiallyVerifiedCount:0,unverifiedCount:0,disprovenCount:0,publicationEligibleCount:0,malformedRecordCount:0,unsafeInputFieldCount:0; reasons=no-evidence,publication-ineligible; malformed=none; presence=deliveryId:y,reviewOutputKey:y,upstreamCorrelationKey:y,policyCorrelationKey:y; handoffOwner=available; redaction=privateOnly:y,rawPayloads:n,publicationFields:n,evidencePayloads:n,githubCommentBody:n,reducerRawPayload:n,discardedRawPayload:n,discardedPublicationFields:n,discardedEvidencePayloads:n

  • Review finding lifecycle: status=normalized; counts=input:1,recorded:1,rejected:0,unsafeInputFields:0; correlation=repo:y,pull:y,reviewOutputKey:y,deliveryId:y,commit:y; statuses=detected:1,open:1,suggested:0,validated:0,revalidated:0,resolved:0,blocked:0,degraded:0; severity=critical:0,major:1,medium:0,minor:0; actionability=actionable:0,needs-human-review:1,needs-reproduction:0,blocked:0,not-actionable:0; reasons=automatic-detected,automatic-open,automatic-review; rejected=none; redaction=privateOnly:y,rawPrompts:n,rawModelOutput:n,candidateBodies:n,toolPayloads:n,secretLike:n,diffs:n,unboundedArrays:n,unsafeFields:0

  • Review validation truth: status=normalized; counts=detected:1,suggested:0,validated:0,revalidated:0,resolved:0,blocked:0,degraded:0,open:1,uncertain:0,inputFindings:1,unsafeInputFields:0; evidence=fresh:0,stale:0,missingValidation:1,missingRevalidation:1; reasons=validation-missing:1; refs=rfl-e6acc5cfae5bb1fc:open:validation-missing:fix:n:validation:n:revalidation:n; correlation=reviewOutputKey:y,deliveryId:y; redaction=privateOnly:y,rawPrompts:n,rawModelOutput:n,candidateBodies:n,replacementText:n,toolPayloads:n,secretLike:n,diffs:n,unboundedArrays:n,unsafeFields:0

  • Files reviewed: 2

  • Findings: 0 critical, 0 major, 0 medium, 0 minor

  • Lines changed: +2 -2

  • Profile: strict (auto, lines changed: 4)

  • Contributor experience: profile-backed (using linked contributor profile guidance)

  • Shadow specialist: lane=docs-config-truth status=skipped reason=no-operator-truth-paths candidateCount=0 decisionCount=0 decisionCounts=candidate:0,duplicate:0,disagreement:0,dismissed:0,unclassifiable:0 duplicateCount=0 disagreementCount=0 dismissedCount=0 unclassifiableCount=0 truncatedCandidateCount=0 metricAvailability=token:n,cost:n,latency:n visiblePublicationDenied=true approvalPublicationDenied=true privateOnly=true shadowOnly=true redacted=raw:n,publication:n,approval:n,unsafe:0 correlationKey=9783520cd4198a93 deliveryId=458e58e0-7099-11f1-9e87-0d09274… reviewOutputKey=kodiai-review-output:v1:inst-10…

  • Review completed: 2026-06-25T13:28:02.512Z

  • Total wall-clock: 2m 59s

  • Phase timings:

    • queue wait: 0ms
    • workspace preparation: 935ms
    • retrieval/context assembly: 3.0s
    • executor handoff: 43s
    • remote runtime: 2m 7s
    • publication: 2.5s
  • Tokens: 28 in / 4,425 out | 0.1162

  • Keyword parsing: No keywords detected

  • Budget behavior: complete (within-budget).

  • Prompt budget: 6 sections, 0 trimmed, 0 bypassed, 0 trimmed tokens.

  • Cache behavior: 2 observations, 1 hits, 1 misses, 0 degraded, 0 bypassed.

  • Continuation behavior: 0 observations, 0 compacted, 0 fallback, 0 degraded, 0 bypassed.

@CastagnaIT CastagnaIT merged commit c04fbd9 into xbmc:Piers Jun 28, 2026
11 checks passed
@CastagnaIT CastagnaIT deleted the dep_bento branch June 28, 2026 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Depends Type: Improvement non-breaking change which improves existing functionality v22 Piers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BENTO4: AP4_CencSampleInfoTable::Create rejects valid IV-only sample aux info (breaks CENC audio playback)

1 participant