Skip to content

Revert "[Session] Add thread sleep when waiting for buffer"#2089

Open
CastagnaIT wants to merge 1 commit into
xbmc:Piersfrom
CastagnaIT:sleep
Open

Revert "[Session] Add thread sleep when waiting for buffer"#2089
CastagnaIT wants to merge 1 commit into
xbmc:Piersfrom
CastagnaIT:sleep

Conversation

@CastagnaIT

@CastagnaIT CastagnaIT commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

Description

This reverts commit 2281ec1.

the attempt to calm down the CPU when there are no data for the demuxer
works on Windows but has side effects on linux causing audio stuttering
for now revert it

Motivation and context

fix #2088

How has this been tested?

youtube video at 4K via ubuntu

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • I have read the Contributing document
  • My code follows the Code Guidelines of this project
  • My change requires a change to the Wiki documentation
  • I have updated the documentation accordingly

@CastagnaIT CastagnaIT added Type: Fix non-breaking change which fixes an issue v22 Piers labels Jul 10, 2026
@kodiai

kodiai Bot commented Jul 10, 2026

Copy link
Copy Markdown

Decision: APPROVE

Issues: none

Evidence:

  • Review prompt covered 1 changed file.
Review Details
  • Files reviewed: 1

  • Findings: 0 critical, 0 major, 0 medium, 0 minor

  • Lines changed: +0 -2

  • Profile: strict (auto, lines changed: 2)

  • Contributor experience: profile-backed (using linked contributor profile guidance)

  • Review completed: 2026-07-10T15:00:05.529Z

  • Total wall-clock: 2m 32s

  • Phase timings:

    • queue wait: 1ms
    • workspace preparation: 832ms
    • retrieval/context assembly: 4.0s
    • executor handoff: 35s
    • remote runtime: 1m 46s
    • publication: 2.9s
  • Tokens: 18 in / 3,010 out | 0.1153

  • Keyword parsing: No keywords detected

  • Budget behavior: complete (within-budget).

  • Prompt budget: 6 sections, 0 trimmed, 0 bypassed, 0 trimmed tokens.

  • Cache behavior: 2 observations, 1 hits, 1 misses, 0 degraded, 0 bypassed.

  • Continuation behavior: 0 observations, 0 compacted, 0 fallback, 0 degraded, 0 bypassed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Fix non-breaking change which fixes an issue v22 Piers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Hitching issues for high bitrate/res video when v22.3.18-Piers used with plugin.video.youtube

1 participant