[weather.ozweather@matrix] 2.1.9

[bossanova808]

Add-on details:

• General

  • Add-on name: OzWeather
  • Add-on ID: weather.ozweather
  • Version number: 2.1.9
  • Kodi/repository version: matrix

• Code location

  • URL: https://github.com/bossanova808/weather.ozweather

Weather forecasting and radar images for Australia using Bureau of Meteorology data. For full features (animated radars & ABC weather videos) - make sure you install the replacement skin files - see information at the addon wiki (https://kodi.wiki/index.php?title=Add-on:Oz_Weather).

Description of changes:

v2.1.9

• Fix ABC weather video scraping due to upstream changes

Checklist:

• My code follows the add-on rules and piracy stance of this project.
• I have read the CONTRIBUTING document
• Each add-on submission should be a single commit with using the following style: [plugin.video.foo] v1.0.0

[kodiai]

Kodiai Addon Check

✅ No issues found by kodi-addon-checker.

[kodiai]

Kodiai Review Summary

What Changed

Updates OzWeather addon to v2.1.9, fixing ABC weather video scraping after upstream API changes.

Reviewed: core logic, docs

Strengths

• ✅ Improved error handling with explicit checks for missing player sources and MP4 formats (abc_video.py:61-63, 69-71)
• ✅ More robust item selection using next() with safe dictionary access instead of hardcoded array index (abc_video.py:60)

Observations

Impact

[MAJOR] weather.ozweather/resources/lib/abc/abc_video.py (76-77): Quality selection logic mixes incompatible metrics
The quality_key function returns fileSize (bytes, potentially millions) or resolution numbers (hundreds to thousands) in the same sort key, causing incorrect quality selection when sources have heterogeneous metadata. Example: an 8MB video (key=8000000) would be chosen over 1080p (key=1080), regardless of actual quality.

Suggestions

• Optional: Consider using a consistent quality metric across all sources (e.g., normalize fileSize to approximate bitrate, or prioritize resolution-based selection with fileSize as tiebreaker)

Verdict

🔴 Address before merging -- 1 blocking issue found (MAJOR)

Review Details

• Files reviewed: 3

• Findings: 0 critical, 2 major, 0 medium, 0 minor (includes 1 from summary observations)

• Lines changed: +41 -7

• Profile: strict (auto, lines changed: 48)

• Contributor experience: profile-backed (using linked contributor profile guidance)

• Review completed: 2026-05-23T04:08:48.882Z

• Total wall-clock: 3m 54s

• Phase timings:

  • queue wait: 0ms
  • workspace preparation: 23s
  • retrieval/context assembly: 6.1s
  • executor handoff: 9.5s
  • remote runtime: 3m 12s
  • publication: 892ms

• Tokens: 60 in / 7,653 out | 0.2455

• Keyword parsing: No keywords detected

[bossanova808]

@kodiai review again, given my reply.

[kodiai]

Kodiai Review Summary

What Changed

Updates OzWeather addon to v2.1.9 to fix ABC weather video scraping following upstream changes to the ABC website JSON structure.

Reviewed: core logic, docs

Strengths

• ✅ Improved error handling with explicit checks for missing player sources and empty URL lists (abc_video.py:61-63, 69-71)
• ✅ Changed from hardcoded array index to dynamic search for player sources, making the code more resilient to JSON structure changes (abc_video.py:60)

Observations

Impact

[MAJOR] weather.ozweather/resources/lib/abc/abc_video.py (75-79): Quality selection mixes incompatible metrics
The quality_key function returns fileSize (bytes, e.g., 50000000) when present, or resolution numbers (e.g., 720, 1080) extracted from labels. When sorted, a 5MB low-quality file (5000000 bytes) will rank higher than a "1080p" source (1080), causing incorrect quality selection when sources have mixed metadata (abc_video.py:75-79).

Suggestions

• Optional: Add URL validation using urlparse instead of basic regex to catch more malformed URLs (abc_video.py:83)
• Future consideration: Add unit tests to verify quality selection behavior with mixed source metadata

Verdict

🔴 Address before merging -- 1 blocking issue(s) found (CRITICAL/MAJOR)

[bossanova808]

@kodiai given all concern addresses, can you approve?

[kodiai]

kodiai response

Decision: NOT APPROVED
Issues:

• (1) [major] weather.ozweather/resources/lib/abc/abc_video.py (75, 81): quality_key returns fileSize (bytes, millions) when present, otherwise resolution (hundreds) parsed from label. Mixing these in one sort key causes incorrect selection if ABC provides fileSize for some sources but not others.

[bossanova808]

@kodiai We discussed this above and you said

You're right — the mixing scenario won't occur in practice. Looking at the actual ABC data structure (weather.ozweather/resources/lib/abc/abc_video.py:75-79), all sources from data['player']['config']['sources'] come from the same JSON object, so they'll consistently either all have fileSize or all lack it.

The current implementation is sound:

    Current reality: All ABC sources include fileSize (as shown in your logged data), so the function consistently returns byte values
    Future-proof: If ABC removes fileSize, all sources would fall back to label parsing together, maintaining consistent comparison

The defensive fallback is reasonable for API resilience without introducing the mixing problem.

[kodiai]

kodiai response

Decision: APPROVE
Issues: none

Evidence:

• All video sources extracted from the same API response (data['player']['config']['sources']), ensuring homogeneous field availability
• User confirmed all ABC sources include fileSize in practice, making label-parsing fallback defensive-only
• Previous acknowledgment was correct: mixing scenario cannot occur with this data structure