update to visualization API 5.0.0 and code cleanups#130
Conversation
|
Decision: APPROVE kodiai responseDecision: APPROVE Evidence:
Review Details
|
AlwinEsch
changed the title
As the std::vector needs always a here a resize to a fixed size makes it more sense to use std::array where based upon fixed size.
Relates to:
```
CMake Deprecation Warning at CMakeLists.txt:2 (cmake_policy):
Compatibility with CMake < 3.10 will be removed from a future version of
CMake.
```
And to have equal to Kodi's used version.
This remove the use on class constructor and makes it direct on value with an e.g. "{0};"
1 participant
Add-on update related to Kodi API change defined on xbmc/xbmc#28278
Further done some code cleanups as some parts was a bit strange and wrong.
Runtime tests on Windows and Linux.
WARNING:
The fact that DirectX no longer works has nothing to do with the changes made here.
For some reason the screen stays black here under Windows 11 and Kodi 22 Piers.
I had already brought Angle in as a test, and there was a display, but it didn't appear correctly.
So it's a major undertaking to get this working correctly again under Windows!
Partly relates to this issue #31 too, only Windows now black and the picture visible there match the screen brought by use of Angle during tests.
I will try to use the latest code from an open pull request on the original for us in the near future.
See here where a newer GL support planned to come in:
The only question now is should we remove the add-on from Windows support immediately or leave it there, maybe it will work for others?