Secured OF prompt#6793
Conversation
|
|
|
@Obihoernchen I would vote for merging this one as-is. I've read the code multiple times and it seems it won't cause any harm. I tried my best to work around the Secured OF thing to see if I could run it on our AC922 POWER9, but that's only available on PowerVM models with LPAR, which is a hardware thing that also can't be emulated. So... I don't have the means to test it. I'm also not aware of anyone who has those machines and would let us borrow them to test this PR, so that's wishful thinking. That said, after reading it multiple times, it seems like it already works and just hasn't been merged. We should merge it. It won't affect any other systems, and if something breaks because of this, we can revert later. Don't want to throw this one away. I'm not sure if @gurevichmark could just help us here with some memory of why it didn't go through... any information would be very helpful. |
The PR is to fix issue #6637
Code contributed by @hgunasin and @wabe1968 in #6637