Skip to content

Secured OF prompt#6793

Draft
gurevichmark wants to merge 2 commits into
xcat2:masterfrom
gurevichmark:secure_of
Draft

Secured OF prompt#6793
gurevichmark wants to merge 2 commits into
xcat2:masterfrom
gurevichmark:secure_of

Conversation

@gurevichmark
Copy link
Copy Markdown
Contributor

@gurevichmark gurevichmark commented Aug 3, 2020

The PR is to fix issue #6637

Code contributed by @hgunasin and @wabe1968 in #6637

@gurevichmark gurevichmark requested review from besawn and cxhong August 3, 2020 19:03
@gurevichmark gurevichmark added this to the 2.16.1 milestone Aug 3, 2020
@gurevichmark gurevichmark linked an issue Aug 3, 2020 that may be closed by this pull request
@gurevichmark gurevichmark marked this pull request as draft August 14, 2020 20:31
@gurevichmark gurevichmark reopened this Aug 18, 2020
@besawn besawn modified the milestones: 2.16.1, 2.16.2 Oct 27, 2020
@peterwywong peterwywong removed this from the 2.16.2 milestone May 17, 2021
@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@viniciusferrao
Copy link
Copy Markdown
Member

@Obihoernchen I would vote for merging this one as-is.

I've read the code multiple times and it seems it won't cause any harm. I tried my best to work around the Secured OF thing to see if I could run it on our AC922 POWER9, but that's only available on PowerVM models with LPAR, which is a hardware thing that also can't be emulated. So... I don't have the means to test it.

I'm also not aware of anyone who has those machines and would let us borrow them to test this PR, so that's wishful thinking.

That said, after reading it multiple times, it seems like it already works and just hasn't been merged. We should merge it. It won't affect any other systems, and if something breaks because of this, we can revert later. Don't want to throw this one away.

I'm not sure if @gurevichmark could just help us here with some memory of why it didn't go through... any information would be very helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

xCAT support for Secured OF (Openfirmware) prompt

5 participants