Skip to content

Backport more XSA-489 fixes, session refresh patches#129

Merged
last-genius merged 1 commit into
8.3from
asv/refresh-session-backport
Apr 30, 2026
Merged

Backport more XSA-489 fixes, session refresh patches#129
last-genius merged 1 commit into
8.3from
asv/refresh-session-backport

Conversation

@last-genius
Copy link
Copy Markdown
Contributor

@last-genius last-genius commented Apr 30, 2026

Main information

Work Item Reference

XCPNG-3236

Context & Motivation

Backport of xapi-project/xen-api#7034, xapi-project/xen-api#7046, xapi-project/xen-api@8bbfa01

Release Target

  • We already defined a release target with the release team.
  • I haven't talked with the release team, but I have a proposed target.
  • I'm not sure, let's talk about it.

Ready for today's release, if we decide to go for it.


Release Notes and Documentation

Explain the change to users

This fixes XSA-489 (CVE-2026-23562, CVE-2026-42486) and fixes an issue where expired sessions would break long migrations

Attention points

None that are known

Documentation update needed

  • Yes
  • No
  • I'm not sure, help me

Testing and regression avoidance

What tests have you performed?

None, the build should be run through the CI. XSA backports have been tested by XenServer.

What's covered by the xcp-ng-tests test suite?

We don't use the xapi RBAC roles, we don't use hvm_serial .

We have a lot of VM/VDI migration tests, with the large QCOW2 volumes taking more than 24h to migrate - these should verify the session refresh patches.


Xen Orchestra Impact

Does this affect existing features in Xen Orchestra, or add new features that could be useful?

  • Yes
  • No

Signed-off-by: Andrii Sultanov <andriy.sultanov@vates.tech>
@last-genius last-genius requested review from a team as code owners April 30, 2026 08:48
@last-genius
Copy link
Copy Markdown
Contributor Author

Scratch build: https://koji.xcp-ng.org/taskinfo?taskID=104506

@stormi
Copy link
Copy Markdown
Member

stormi commented Apr 30, 2026

fixes an issue where expired sessions would break long migrations

This change in particular may require particular attention in testing. Are we ready to rely on our CI solely, for this one?

@last-genius
Copy link
Copy Markdown
Contributor Author

fixes an issue where expired sessions would break long migrations

This change in particular may require particular attention in testing. Are we ready to rely on our CI solely, for this one?

it's been merged upstream for a long time already, and I expect it to have gone through some XenServer testing. IMO, the worst case is that the change doesn't quite achieve what it wants to, but it shouldn't break anything that's not already broken

@stormi
Copy link
Copy Markdown
Member

stormi commented Apr 30, 2026

fixes an issue where expired sessions would break long migrations

This change in particular may require particular attention in testing. Are we ready to rely on our CI solely, for this one?

it's been merged upstream for a long time already, and I expect it to have gone through some XenServer testing. IMO, the worst case is that the change doesn't quite achieve what it wants to, but it shouldn't break anything that's not already broken

That's the kind of information I went looking for in the PR description, but the lack of details there let me wondering. Thanks for the precisions.

Copy link
Copy Markdown
Contributor

@rzr rzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patches are well tracked, this is appreciated :)

@last-genius last-genius merged commit 8949745 into 8.3 Apr 30, 2026
3 checks passed
@last-genius last-genius deleted the asv/refresh-session-backport branch April 30, 2026 09:24
@last-genius
Copy link
Copy Markdown
Contributor Author

Build to v8.3-incoming: https://koji.xcp-ng.org/buildinfo?buildID=5578

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants