Skip to content

8.3 rebase xs 20250328#91

Merged
glehmann merged 3 commits into
masterfrom
8.3-rebase-XS-20250328
Apr 17, 2025
Merged

8.3 rebase xs 20250328#91
glehmann merged 3 commits into
masterfrom
8.3-rebase-XS-20250328

Conversation

@stormi
Copy link
Copy Markdown
Member

@stormi stormi commented Mar 28, 2025

Naïve merge. Don't trust me, nor on packaging, nor on patches that I haven't reviewed at all anyway.

Signed-off-by: Samuel Verschelde <stormi-xcp@ylix.fr>
@stormi stormi requested review from a team March 28, 2025 17:55
@stormi stormi marked this pull request as draft March 28, 2025 17:55
@gthvn1
Copy link
Copy Markdown
Member

gthvn1 commented Mar 31, 2025

@stormi should't we also rebase xs-opam before? Because xs-opam provides the opam switch to build xapi . Or maybe there are no changes in the xs-opam repo?

@gthvn1
Copy link
Copy Markdown
Member

gthvn1 commented Mar 31, 2025

Ok in fact we are probably using directly the upstream xs-opam repo so no need to worry about it.

@gthvn1
Copy link
Copy Markdown
Member

gthvn1 commented Mar 31, 2025

NOTE: I was asking because with my current implementation of qcow-tool I rely on xs-opam 6.88 so I hope this "rebase" would also use the new version of xs-opam ;)

@stormi
Copy link
Copy Markdown
Member Author

stormi commented Mar 31, 2025

We're actually rebasing on xs-opam-repo-6.87.0-1.xs8.src.rpm but I haven't reached that letter yet (doing things in the alphabetical order)

@gthvn1 gthvn1 force-pushed the 8.3-rebase-XS-20250328 branch 2 times, most recently from 51807a6 to 6fd1fb9 Compare April 1, 2025 08:10
Comment thread SPECS/xapi.spec
Comment thread SPECS/xapi.spec
Comment thread SPECS/xapi.spec
Copy link
Copy Markdown
Member

@gthvn1 gthvn1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how to handle things related to xs9 so I added questions for @xcp-ng-rpms/os-platform-release (I guess).

Comment thread SPECS/xapi.spec Outdated
Comment thread SPECS/xapi.spec Outdated
# Cherry-picked issues with metrics from 25.13
Patch1008: 0008-CA-408126-rrd-Do-not-lose-ds_min-max-when-adding-to-.patch
Patch1009: 0009-CA-408126-follow-up-Fix-negative-ds_min-and-RRD-valu.patch

Copy link
Copy Markdown
Member

@gthvn1 gthvn1 Apr 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need to cherry-pick this one as well: xapi-project/xen-api@4ee32f2
it is in 25.15

Copy link
Copy Markdown
Member Author

@stormi stormi Apr 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This backport, as well as the other two, should be in a separate commit, not in the merge commit.

Arguably the rest of the patchqueue update could be in its own commit too:

  • import commit
  • merge commit, leaving TODOs
  • patch update commit, only updating the existing patch queue
  • a commit to add backports that are already known to be necessary

Each time refining the changelog. If you don't want a changelog entry to look like it's complete when it isn't yet, you can add - WIP at the end of the line, and remove it in the last commit:

* Fri Mar 28 2025 Samuel Verschelde <stormi-xcp@ylix.fr> - 25.6.0-1.1 - WIP

Lastly, as you're doing most of the work on patches, you could update the date and put your name instead of mine.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@glehmann you moved all patch updates to a separate commit, which is fine, but above I was asking that we moved new backports to their own commit, to separate them from mere adaptation to the new sources.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the only remaining comment. I still think added patches would better be in a separate commit, but I'm ready to approve as is.

Comment thread SPECS/xapi.spec
Comment thread SPECS/xapi.spec
Comment thread SPECS/xapi.spec Outdated
Comment thread SPECS/xapi.spec
Comment thread SPECS/xapi.spec
Comment thread SPECS/xapi.spec Outdated
@glehmann glehmann force-pushed the 8.3-rebase-XS-20250328 branch 2 times, most recently from 1ba4702 to 36d24bd Compare April 16, 2025 08:24
Comment thread SPECS/xapi.spec Outdated
Comment thread SPECS/xapi.spec
Comment thread SPECS/xapi.spec Outdated
Comment thread SPECS/xapi.spec Outdated
@stormi stormi marked this pull request as ready for review April 16, 2025 10:45
Comment thread SPECS/xapi.spec
@glehmann glehmann force-pushed the 8.3-rebase-XS-20250328 branch from 36d24bd to b0b5d1e Compare April 16, 2025 13:36
@glehmann
Copy link
Copy Markdown
Contributor

scratch build: https://koji.xcp-ng.org/taskinfo?taskID=81356

@glehmann
Copy link
Copy Markdown
Contributor

I guess I should have run the scratch build on the v8.3-u-gtn1 target, in order to have the up-to-date xs-opam-repo? (it's not failed yet, just wondering)

@glehmann
Copy link
Copy Markdown
Contributor

it failed because it doesn't have the expected xs-opam-repo, as expected!
new scratch build based on the v8.3-u-gtn1 target: https://koji.xcp-ng.org/taskinfo?taskID=81359

Comment thread SPECS/xapi.spec Outdated
@glehmann glehmann force-pushed the 8.3-rebase-XS-20250328 branch from b0b5d1e to 01ab72a Compare April 16, 2025 14:59
Comment thread SPECS/xapi.spec Outdated
Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
@glehmann glehmann force-pushed the 8.3-rebase-XS-20250328 branch 2 times, most recently from 7294ac5 to 0fb2f74 Compare April 16, 2025 15:18
@stormi stormi requested review from gthvn1 and removed request for a team April 16, 2025 15:37
Comment thread SPECS/xapi.spec Outdated
Comment thread SPECS/xapi.spec Outdated
Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
@glehmann glehmann force-pushed the 8.3-rebase-XS-20250328 branch from 0fb2f74 to 1944a85 Compare April 16, 2025 15:56
@glehmann glehmann merged commit 0bc1152 into master Apr 17, 2025
1 check passed
@glehmann glehmann deleted the 8.3-rebase-XS-20250328 branch April 17, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants