8.3 rebase xs 20250328#91
Conversation
Signed-off-by: Samuel Verschelde <stormi-xcp@ylix.fr>
|
@stormi should't we also rebase xs-opam before? Because xs-opam provides the opam switch to build xapi . Or maybe there are no changes in the xs-opam repo? |
|
Ok in fact we are probably using directly the upstream xs-opam repo so no need to worry about it. |
|
NOTE: I was asking because with my current implementation of qcow-tool I rely on xs-opam 6.88 so I hope this "rebase" would also use the new version of xs-opam ;) |
|
We're actually rebasing on |
51807a6 to
6fd1fb9
Compare
gthvn1
left a comment
There was a problem hiding this comment.
I'm not sure how to handle things related to xs9 so I added questions for @xcp-ng-rpms/os-platform-release (I guess).
| # Cherry-picked issues with metrics from 25.13 | ||
| Patch1008: 0008-CA-408126-rrd-Do-not-lose-ds_min-max-when-adding-to-.patch | ||
| Patch1009: 0009-CA-408126-follow-up-Fix-negative-ds_min-and-RRD-valu.patch | ||
|
|
There was a problem hiding this comment.
We will need to cherry-pick this one as well: xapi-project/xen-api@4ee32f2
it is in 25.15
There was a problem hiding this comment.
This backport, as well as the other two, should be in a separate commit, not in the merge commit.
Arguably the rest of the patchqueue update could be in its own commit too:
- import commit
- merge commit, leaving TODOs
- patch update commit, only updating the existing patch queue
- a commit to add backports that are already known to be necessary
Each time refining the changelog. If you don't want a changelog entry to look like it's complete when it isn't yet, you can add - WIP at the end of the line, and remove it in the last commit:
* Fri Mar 28 2025 Samuel Verschelde <stormi-xcp@ylix.fr> - 25.6.0-1.1 - WIP
Lastly, as you're doing most of the work on patches, you could update the date and put your name instead of mine.
There was a problem hiding this comment.
@glehmann you moved all patch updates to a separate commit, which is fine, but above I was asking that we moved new backports to their own commit, to separate them from mere adaptation to the new sources.
There was a problem hiding this comment.
That's the only remaining comment. I still think added patches would better be in a separate commit, but I'm ready to approve as is.
1ba4702 to
36d24bd
Compare
36d24bd to
b0b5d1e
Compare
|
scratch build: https://koji.xcp-ng.org/taskinfo?taskID=81356 |
|
I guess I should have run the scratch build on the |
|
it failed because it doesn't have the expected |
b0b5d1e to
01ab72a
Compare
Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
7294ac5 to
0fb2f74
Compare
Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
0fb2f74 to
1944a85
Compare
Naïve merge. Don't trust me, nor on packaging, nor on patches that I haven't reviewed at all anyway.