Skip to content

Add check for array contiguity #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rpreen merged 1 commit into from
Jul 16, 2025
Merged

Add check for array contiguity #199

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions xcsf/pybind_wrapper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,14 @@ class XCS
// access input
const py::buffer_info buf_x = X.request();
const py::buffer_info buf_y = Y.request();
// check array contiguity
// https://github.com/pybind/pybind11/discussions/4211#discussioncomment-3905115
const int C_CONTIGUOUS =
py::detail::npy_api::constants::NPY_ARRAY_C_CONTIGUOUS_;
if (!(C_CONTIGUOUS == (X.flags() & C_CONTIGUOUS)) ||
!(C_CONTIGUOUS == (Y.flags() & C_CONTIGUOUS))) {
throw std::invalid_argument("X and Y must be C-contiguous");
}
// check input shape
if (buf_x.ndim < 1 || buf_x.ndim > 2) {
throw std::invalid_argument("X must be 1 or 2-D array");
Expand Down Expand Up @@ -584,6 +592,13 @@ class XCS
predict(const py::array_t<double> X, const py::object &cover)
{
const py::buffer_info buf_x = X.request();
// check array contiguity
// https://github.com/pybind/pybind11/discussions/4211#discussioncomment-3905115
const int C_CONTIGUOUS =
py::detail::npy_api::constants::NPY_ARRAY_C_CONTIGUOUS_;
if (!(C_CONTIGUOUS == (X.flags() & C_CONTIGUOUS))) {
throw std::invalid_argument("X must be C-contiguous");
}
if (buf_x.ndim < 1 || buf_x.ndim > 2) {
throw std::invalid_argument("predict(): X must be 1 or 2-D array");
}
Expand Down
Loading