Skip to content

bug: fix constant prediction early stopping rollback#214

Merged
rpreen merged 2 commits intomasterfrom
fix_constant_prediction_rollback
Sep 11, 2025
Merged

bug: fix constant prediction early stopping rollback#214
rpreen merged 2 commits intomasterfrom
fix_constant_prediction_rollback

Conversation

@rpreen
Copy link
Copy Markdown
Member

@rpreen rpreen commented Sep 11, 2025

fix constant prediction early stopping rollback - currently predictions are reset upon copying so get lost when performing a rollback during early stopping - this does NOT affect NLMS or RLS, etc., since the weights are copied and the predictions are computed

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.59%. Comparing base (8d22d41) to head (e0bbafa).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #214   +/-   ##
=======================================
  Coverage   70.59%   70.59%           
=======================================
  Files          61       61           
  Lines        8940     8941    +1     
  Branches      934      934           
=======================================
+ Hits         6311     6312    +1     
  Misses       2629     2629           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rpreen rpreen changed the title fix constant prediction early stopping rollback bug: fix constant prediction early stopping rollback Sep 11, 2025
@rpreen rpreen merged commit edcfd58 into master Sep 11, 2025
11 checks passed
@rpreen rpreen deleted the fix_constant_prediction_rollback branch September 11, 2025 15:19
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant