Unable to download music from URI source when running maven against proxy server

[plumstone]

Checklist

• I am able to reproduce the bug with the latest version
• I made sure that there are no existing issues - open or closed - which I could contribute my information to.
• I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
• This issue contains only one bug.

Affected version

1.0.3

Description of the problem

Currently it seems like the plugin does not support maven builds running against a proxy server since the download of music files fail with a connect timeout.

Steps to reproduce the bug

1. Set a proxy in the maven settings.xml
2. Set a musicSource where the uri points to a web address (e.g. https://incompetech.com/music/royalty-free/mp3-royaltyfree/Corncob.mp3)
3. Run the maven build

Additional information

[WARNING] Failed to play stream
java.io.UncheckedIOException: java.net.ConnectException: Connection timed out: connect
    at software.xdev.maven.music.MusicSource.openInputStream (MusicSource.java:107)
    at software.xdev.maven.music.MusicMojo.runOnThread (MusicMojo.java:150)
    at java.lang.Thread.run (Thread.java:1583)
Caused by: java.net.ConnectException: Connection timed out: connect
    at sun.nio.ch.Net.connect0 (Native Method)
    at sun.nio.ch.Net.connect (Net.java:589)
    at sun.nio.ch.Net.connect (Net.java:578)
    at sun.nio.ch.NioSocketImpl.connect (NioSocketImpl.java:583)
    at java.net.SocksSocketImpl.connect (SocksSocketImpl.java:327)
    at java.net.Socket.connect (Socket.java:751)
    at sun.security.ssl.SSLSocketImpl.connect (SSLSocketImpl.java:304)
    at sun.security.ssl.BaseSSLSocketImpl.connect (BaseSSLSocketImpl.java:181)
    at sun.net.NetworkClient.doConnect (NetworkClient.java:183)
    at sun.net.www.http.HttpClient.openServer (HttpClient.java:531)
    at sun.net.www.http.HttpClient.openServer (HttpClient.java:636)
    at sun.net.www.protocol.https.HttpsClient.<init> (HttpsClient.java:264)
    at sun.net.www.protocol.https.HttpsClient.New (HttpsClient.java:377)
    at sun.net.www.protocol.https.AbstractDelegateHttpsURLConnection.getNewHttpClient (AbstractDelegateHttpsURLConnection.java:193)
    at sun.net.www.protocol.http.HttpURLConnection.plainConnect0 (HttpURLConnection.java:1252)
    at sun.net.www.protocol.http.HttpURLConnection.plainConnect (HttpURLConnection.java:1138)
    at sun.net.www.protocol.https.AbstractDelegateHttpsURLConnection.connect (AbstractDelegateHttpsURLConnection.java:179)
    at sun.net.www.protocol.http.HttpURLConnection.getInputStream0 (HttpURLConnection.java:1690)
    at sun.net.www.protocol.http.HttpURLConnection.getInputStream (HttpURLConnection.java:1614)
    at sun.net.www.protocol.https.HttpsURLConnectionImpl.getInputStream (HttpsURLConnectionImpl.java:223)
    at java.net.URL.openStream (URL.java:1325)
    at software.xdev.maven.music.MusicSource.openInputStream (MusicSource.java:103)
    at software.xdev.maven.music.MusicMojo.runOnThread (MusicMojo.java:150)
    at java.lang.Thread.run (Thread.java:1583)

[AB-xdev]

So I had a look into this topic and sadly it looks way to complex to convert Maven proxies to Java Proxies and use them there.

I also think that using a proxy is quite a niche nowadays - we haven't encountered one in a lot of different projects for years.

For this case: I think it's a lot simpler/easier to just download the song and use the downloaded file instead.

We will not do any further work here for now.

Anyway if someone still wants to implement the proxy support: Feel free to do so but the implementation should be well designed and lightweight.