Skip to content

Commit 9f38327

Browse files
committed
Fix NPE in FastCookieFinder
1 parent f5da3dc commit 9f38327

2 files changed

Lines changed: 15 additions & 3 deletions

File tree

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
# 2.2.3
2+
* oauth2-oidc-remember-me
3+
* Fix NPE in `FastCookieFinder`
4+
15
# 2.2.2
26
* oauth2-oidc-remember-me
37
* Handle cookie path correctly

oauth2-oidc/src/main/java/software/xdev/sse/oauth2/util/FastCookieFinder.java

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,17 @@ public static Optional<Cookie> findCookie(final HttpServletRequest request, fina
2929
return Optional.ofNullable(request.getHeader("Cookie"))
3030
// Quick check if value is present
3131
.filter(h -> h.contains(cookieName))
32-
.flatMap(x -> Stream.of(request.getCookies())
33-
.filter(c -> cookieName.equals(c.getName()))
34-
.findFirst());
32+
.flatMap(x -> {
33+
final Cookie[] cookies = request.getCookies();
34+
if(cookies == null)
35+
{
36+
return Optional.empty();
37+
}
38+
39+
return Stream.of(cookies)
40+
.filter(c -> cookieName.equals(c.getName()))
41+
.findFirst();
42+
});
3543
}
3644

3745
private FastCookieFinder()

0 commit comments

Comments
 (0)