Merge pull request #354 from xdev-software/develop

Release

Author: AB-xdev

CHANGELOG.md

@@ -1,3 +1,6 @@
+# 2.5.0
+* New module `caching-validation-provider`
+
 # 2.4.0
 * oauth2-oidc-remember-me
   * Prefer use of UTC based `Instant` instead of `LocalDateTime`

bom/pom.xml

@@ -6,7 +6,7 @@
 
 	<groupId>software.xdev.sse</groupId>
 	<artifactId>bom</artifactId>
-	<version>2.4.1-SNAPSHOT</version>
+	<version>2.5.0-SNAPSHOT</version>
 	<packaging>pom</packaging>
 
 	<name>bom</name>
@@ -48,65 +48,70 @@
 
 	<dependencyManagement>
 		<dependencies>
+			<dependency>
+				<groupId>software.xdev.sse</groupId>
+				<artifactId>caching-validation-provider</artifactId>
+				<version>2.5.0-SNAPSHOT</version>
+			</dependency>
 			<dependency>
 				<groupId>software.xdev.sse</groupId>
 				<artifactId>client-storage</artifactId>
-				<version>2.4.1-SNAPSHOT</version>
+				<version>2.5.0-SNAPSHOT</version>
 			</dependency>
 			<dependency>
 				<groupId>software.xdev.sse</groupId>
 				<artifactId>crypto-symmetric</artifactId>
-				<version>2.4.1-SNAPSHOT</version>
+				<version>2.5.0-SNAPSHOT</version>
 			</dependency>
 			<dependency>
 				<groupId>software.xdev.sse</groupId>
 				<artifactId>crypto-symmetric-managed</artifactId>
-				<version>2.4.1-SNAPSHOT</version>
+				<version>2.5.0-SNAPSHOT</version>
 			</dependency>
 			<dependency>
 				<groupId>software.xdev.sse</groupId>
 				<artifactId>codec-sha256</artifactId>
-				<version>2.4.1-SNAPSHOT</version>
+				<version>2.5.0-SNAPSHOT</version>
 			</dependency>
 			<dependency>
 				<groupId>software.xdev.sse</groupId>
 				<artifactId>csp</artifactId>
-				<version>2.4.1-SNAPSHOT</version>
+				<version>2.5.0-SNAPSHOT</version>
 			</dependency>
 			<dependency>
 				<groupId>software.xdev.sse</groupId>
 				<artifactId>metrics</artifactId>
-				<version>2.4.1-SNAPSHOT</version>
+				<version>2.5.0-SNAPSHOT</version>
 			</dependency>
 			<dependency>
 				<groupId>software.xdev.sse</groupId>
 				<artifactId>oauth2-oidc</artifactId>
-				<version>2.4.1-SNAPSHOT</version>
+				<version>2.5.0-SNAPSHOT</version>
 			</dependency>
 			<dependency>
 				<groupId>software.xdev.sse</groupId>
 				<artifactId>oauth2-oidc-remember-me</artifactId>
-				<version>2.4.1-SNAPSHOT</version>
+				<version>2.5.0-SNAPSHOT</version>
 			</dependency>
 			<dependency>
 				<groupId>software.xdev.sse</groupId>
 				<artifactId>vaadin</artifactId>
-				<version>2.4.1-SNAPSHOT</version>
+				<version>2.5.0-SNAPSHOT</version>
 			</dependency>
 			<dependency>
 				<groupId>software.xdev.sse</groupId>
 				<artifactId>web</artifactId>
-				<version>2.4.1-SNAPSHOT</version>
+				<version>2.5.0-SNAPSHOT</version>
 			</dependency>
 			<dependency>
 				<groupId>software.xdev.sse</groupId>
 				<artifactId>web-sidecar-actuator</artifactId>
-				<version>2.4.1-SNAPSHOT</version>
+				<version>2.5.0-SNAPSHOT</version>
 			</dependency>
 			<dependency>
 				<groupId>software.xdev.sse</groupId>
 				<artifactId>web-sidecar-common</artifactId>
-				<version>2.4.1-SNAPSHOT</version>
+				<version>2.5.0-SNAPSHOT</version>
 			</dependency>
 		</dependencies>
 	</dependencyManagement>

caching-validation-provider/README.md

@@ -0,0 +1,17 @@
+# Caching Validation Provider
+
+Utility to reduce instantiation of Validators.
+
+The underlying problem can be observed when enabling `DEBUG` logging for `org.hibernate.validator` and was described in [spring-projects/spring-boot#50597](https://github.com/spring-projects/spring-boot/issues/50597).
+The Validator(Factory) get's instantiated a lot:
+1. By `JakartaValidationBackgroundPreinitializer`
+2. By Hibernate itself when `spring.jpa.properties.jakarta.persistence.validation.mode` is NOT set to `none`
+3. For every `@Validated` annotation in `ConfigurationPropertiesBinder` (in SSE this can happen up to 8 times)
+4. As `defaultValidator` in `LocalValidatorFactoryBean`
+
+The problem is worked around by:
+* Caching ValidatorFactories for identical configurations
+  * Wrapping configuration in a comparable object so that it can be determined if it's identical or not
+* Disabling XML configuration by default (can be re-enabled by setting system property `validation.xml-configuration.enable=true`)
+
+NOTE: The code here is not directly related to SSE (it hooks itself into `jakarta.validation.spi.ValidationProvider` to patch the observed problems) but it - for now - lives here because SSE is heavily affected by it.