Skip to content

Commit fc3f70b

Browse files
committed
Fix PMD II
1 parent 016f045 commit fc3f70b

File tree

2 files changed

+11
-11
lines changed

2 files changed

+11
-11
lines changed

oauth2-oidc-remember-me/src/main/java/software/xdev/sse/oauth2/rememberme/OAuth2CookieRememberMeServices.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -256,8 +256,8 @@ public Authentication autoLogin(final HttpServletRequest request, final HttpServ
256256
return null;
257257
}
258258

259-
final Cookie idCookie = optIdCookie.get();
260-
final Cookie payloadCookie = optPayloadCookie.get();
259+
final Cookie idCookie = optIdCookie.orElseThrow();
260+
final Cookie payloadCookie = optPayloadCookie.orElseThrow();
261261

262262
try
263263
{
@@ -737,13 +737,13 @@ public <O extends RememberMeAuthenticationProvider> O postProcess(final O object
737737
// Required for filtering correctly in provider
738738
protected static class RestoredOAuth2AuthenticationToken extends OAuth2AuthenticationToken
739739
{
740-
public RestoredOAuth2AuthenticationToken(final OAuth2AuthenticationToken copyFrom)
740+
protected RestoredOAuth2AuthenticationToken(final OAuth2AuthenticationToken copyFrom)
741741
{
742742
super(copyFrom.getPrincipal(), copyFrom.getAuthorities(), copyFrom.getAuthorizedClientRegistrationId());
743743
this.setDetails(copyFrom.getDetails());
744744
}
745745

746-
public RestoredOAuth2AuthenticationToken(
746+
protected RestoredOAuth2AuthenticationToken(
747747
final OAuth2AuthenticationToken copyFrom,
748748
final OAuth2User enrichedUser)
749749
{
@@ -755,7 +755,7 @@ public RestoredOAuth2AuthenticationToken(
755755

756756
protected static class OAuth2CookieRememberMeAuthenticationProvider extends RememberMeAuthenticationProvider
757757
{
758-
public OAuth2CookieRememberMeAuthenticationProvider()
758+
protected OAuth2CookieRememberMeAuthenticationProvider()
759759
{
760760
super("X");
761761
}

oauth2-oidc-remember-me/src/test/java/software/xdev/sse/oauth2/rememberme/serializer/DefaultOAuth2CookieRememberMeAuthSerializerTest.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -138,28 +138,28 @@ void performAttack(
138138
this.serializeAndDeserialize(serializer, data);
139139
}
140140

141-
public static class AttackPerformer
141+
static class AttackPerformer
142142
{
143-
public static final String SUCCESS_INDICATOR = "ATTACK_PERF_SUCCESS";
143+
static final String SUCCESS_INDICATOR = "ATTACK_PERF_SUCCESS";
144144

145145
private String id;
146146

147147
// Required for Jackson
148-
public AttackPerformer()
148+
AttackPerformer()
149149
{
150150
}
151151

152-
public AttackPerformer(final String id)
152+
AttackPerformer(final String id)
153153
{
154154
this.id = id;
155155
}
156156

157-
public String getId()
157+
String getId()
158158
{
159159
return this.id;
160160
}
161161

162-
public void setId(final String id)
162+
void setId(final String id)
163163
{
164164
this.id = id;
165165

0 commit comments

Comments
 (0)