Add support for operator_type to allow keyword targeting criterion (#215)

jamesy829 · osowskit · tushdante · web-flow · commit 3bce052de59d · 2020-10-22T11:16:06.000-07:00
* Add targeting_value property to event targeting criteria

* Add operator_type to support keyword targeting criterion relationship

Co-authored-by: Tom Osowski &lt;osowskit@gmail.com&gt;
Co-authored-by: Tushar Bhushan &lt;tushar.bhushan@yahoo.com&gt;
diff --git a/lib/twitter-ads/campaign/targeting_criteria.rb b/lib/twitter-ads/campaign/targeting_criteria.rb
@@ -21,6 +21,7 @@ class TargetingCriteria
     property :line_item_id
     property :targeting_type
     property :targeting_value
+    property :operator_type
     property :tailored_audience_expansion, type: :bool
     property :location_type
 
diff --git a/lib/twitter-ads/targeting_criteria/event.rb b/lib/twitter-ads/targeting_criteria/event.rb
@@ -21,6 +21,7 @@ class Event
     property :gender_breakdown_percentage, read_only: true
     property :device_breakdown_percentage, read_only: true
     property :country_breakdown_percentage, read_only: true
+    property :targeting_value, read_only: true
 
     RESOURCE_COLLECTION = "/#{TwitterAds::API_VERSION}/" \
                           'targeting_criteria/events' # @api private
diff --git a/spec/twitter-ads/campaign/targeting_criteria_spec.rb b/spec/twitter-ads/campaign/targeting_criteria_spec.rb
@@ -30,6 +30,7 @@
     line_item_id
     targeting_type
     targeting_value
+    operator_type
     tailored_audience_expansion
   )
 

Original file line number	Diff line number	Diff line change
`@@ -30,6 +30,7 @@`
`30`	`30`	`line_item_id`
`31`	`31`	`targeting_type`
`32`	`32`	`targeting_value`
	`33`	`+ operator_type`
`33`	`34`	`tailored_audience_expansion`
`34`	`35`	`)`
`35`	`36`