Skip to content

Commit b2988b2

Browse files
authored
Improve Travis CI Tests (#196)
* Update .travis.yml * Update README We no longer test JRuby since #133 * Set min version to 2.4 * Allow bundler 2 * Update .rubocop.yml
1 parent 2ec29ac commit b2988b2

4 files changed

Lines changed: 24 additions & 17 deletions

File tree

.rubocop.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Style & Quality Overrides
22
AllCops:
3-
TargetRubyVersion: 2.3
3+
TargetRubyVersion: 2.4
44
Exclude:
55
- 'bin/**/*'
66
- 'vendor/bundle/**/*'
@@ -138,3 +138,6 @@ Layout/EmptyLineAfterMagicComment:
138138

139139
Metrics/BlockLength:
140140
Enabled: false
141+
142+
Performance/RegexpMatch:
143+
Enabled: false

.travis.yml

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,23 @@
11
language: ruby
22

3-
install: ruby -S bundle install --without development
3+
before_install:
4+
- bundle config without 'development'
5+
6+
install: bundle install
47
script: bundle exec rake
58

69
branches:
710
only:
811
- master
9-
- stable
1012

1113
matrix:
1214
fast_finish: true
1315
allow_failures:
1416
- rvm: ruby-head
15-
- rvm: rbx
17+
- rvm: rbx-2
1618
include:
17-
- rvm: 2.3.0
18-
- rvm: 2.4.0
19-
- rvm: 2.5.0
20-
- rvm: 2.6.0
19+
- rvm: 2.6.3
20+
- rvm: 2.5.5
21+
- rvm: 2.4.6
2122
- rvm: ruby-head
22-
- rvm: rbx
23+
- rvm: rbx-2

README.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,12 +48,11 @@ For more help please see our [Examples and Guides](https://github.com/twitterdev
4848

4949
## Compatibility & Versioning
5050

51-
This project is designed to work with Ruby 2.3.0 or greater. While it may work on other version of Ruby, below are the platform and runtime versions we officially support and regularly test against.
51+
This project is designed to work with Ruby 2.4.0 or greater. While it may work on other version of Ruby, below are the platform and runtime versions we officially support and regularly test against.
5252

5353
Platform | Versions
5454
-------- | --------
55-
MRI | 2.3.0, 2.4.x, 2.5.x, 2.6.x
56-
JRuby | 1.7.x, 9.0.0.0 (JDK7, JDK8, OpenJDK)
55+
MRI | 2.4.x, 2.5.x, 2.6.x
5756
Rubinius | 2.4.x, 2.5.x
5857

5958
All releases adhere to strict [semantic versioning](http://semver.org). For Example, major.minor.patch-pre (aka. stick.carrot.oops-peek).

twitter-ads.gemspec

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,20 @@ Gem::Specification.new do |s|
88
s.version = TwitterAds::VERSION
99
s.platform = Gem::Platform::RUBY
1010
s.licenses = ['MIT']
11-
s.authors = ['Brandon Black', 'John Babich', 'Jacob Petrie']
11+
s.authors = [
12+
'John Babich',
13+
'Tushar Bhushan',
14+
'Juan Shishido',
15+
'Thomas Osowski',
16+
'Shohei Maeda'
17+
]
1218
s.email = ['twitterdev-ads@twitter.com']
1319
s.homepage = 'https://github.com/twitterdev/twitter-ruby-ads-sdk'
1420
s.description = 'The officially supported Twitter Ads API SDK for Ruby.'
1521
s.summary = s.description
1622

17-
s.required_ruby_version = '>= 2.3.0'
18-
s.required_rubygems_version = '>= 2.3.0'
23+
s.required_ruby_version = '>= 2.4.0'
24+
s.required_rubygems_version = '>= 2.6.0'
1925

2026
if File.exist?('private.pem')
2127
s.signing_key = 'private.pem'
@@ -27,8 +33,6 @@ Gem::Specification.new do |s|
2733
s.add_dependency 'multi_json', '~> 1.11'
2834
s.add_dependency 'oauth', '~> 0.4'
2935

30-
s.add_development_dependency 'bundler', '~> 1.6'
31-
3236
s.files = Dir.glob('{bin,lib}/**/*')
3337
s.files += %w(twitter-ads.gemspec LICENSE README.md CONTRIBUTING.md Rakefile)
3438
s.test_files = Dir.glob('{spec,feature}/**/*')

0 commit comments

Comments
 (0)