Skip tests requiring block generation when RPC miner unavailable

Add supports_mining probe to DashCoreNode that detects whether the
dashd binary has generatetoaddress compiled in. Some builds (e.g.
Windows release binaries) ship without the RPC miner. Tests that
generate blocks after initial sync now skip gracefully instead of
panicking.

Author: xdustinface

dash-spv-ffi/tests/callback_integration_test.rs

@@ -129,6 +129,10 @@ fn test_callbacks_post_sync_transactions_and_disconnect() {
     let Some(mut dashd) = rt.block_on(DashdTestContext::new()) else {
         return;
     };
+    if !dashd.supports_mining {
+        eprintln!("Skipping test (dashd RPC miner not available)");
+        return;
+    }
 
     unsafe {
         let ctx = FFITestContext::new(dashd.addr);

dash-spv-ffi/tests/dashd_ffi_sync_test.rs

@@ -69,6 +69,10 @@ fn test_ffi_sync_then_generate_blocks() {
     let Some(mut dashd) = rt.block_on(DashdTestContext::new()) else {
         return;
     };
+    if !dashd.supports_mining {
+        eprintln!("Skipping test (dashd RPC miner not available)");
+        return;
+    }
 
     unsafe {
         let ctx = FFITestContext::new(dashd.addr);

dash-spv/src/test_utils/context.rs

@@ -21,6 +21,7 @@ pub struct DashdTestContext {
     pub addr: SocketAddr,
     pub expected_height: u32,
     pub wallet: WalletFile,
+    pub supports_mining: bool,
     _datadir: TempDir,
 }
 
@@ -67,11 +68,17 @@ impl DashdTestContext {
         let expected_height = node.get_block_count().await;
         info!("Dashd has {} blocks", expected_height);
 
+        let supports_mining = node.supports_mining();
+        if !supports_mining {
+            info!("RPC miner not available (tests requiring block generation will be skipped)");
+        }
+
         Some(DashdTestContext {
             node,
             addr,
             expected_height,
             wallet,
+            supports_mining,
             _datadir: datadir,
         })
     }

dash-spv/src/test_utils/node.rs

@@ -316,6 +316,25 @@ impl DashCoreNode {
         address.assume_checked()
     }
 
+    /// Check if the connected dashd supports `generatetoaddress` (RPC miner).
+    ///
+    /// Some builds (e.g. Windows release binaries) ship without the RPC miner compiled in.
+    pub fn supports_mining(&self) -> bool {
+        let client = self.rpc_client();
+        let addr = self.get_new_address();
+        match client.generate_to_address(0, &addr) {
+            Ok(_) => true,
+            Err(dashcore_rpc::Error::JsonRpc(dashcore_rpc::jsonrpc::Error::Rpc(ref e)))
+                if e.message.contains("not available") =>
+            {
+                false
+            }
+            // Any other error (auth, network) still counts as "available" —
+            // a real generate call will surface the actual error.
+            Err(_) => true,
+        }
+    }
+
     /// Generate blocks to the given address.
     pub fn generate_blocks(&self, count: u64, address: &Address) -> Vec<BlockHash> {
         let client = self.rpc_client();

dash-spv/tests/dashd_sync.rs

@@ -760,6 +760,10 @@ async fn test_sync_then_generate_blocks() {
     let Some(ctx) = TestContext::new().await else {
         return;
     };
+    if !ctx.dashd.supports_mining {
+        eprintln!("Skipping test (dashd RPC miner not available)");
+        return;
+    }
 
     let (wallet, wallet_id) = ctx.create_wallet();
 
@@ -828,6 +832,10 @@ async fn test_multiple_transactions_in_single_block() {
     let Some(ctx) = TestContext::new().await else {
         return;
     };
+    if !ctx.dashd.supports_mining {
+        eprintln!("Skipping test (dashd RPC miner not available)");
+        return;
+    }
 
     let (wallet, wallet_id) = ctx.create_wallet();
 
@@ -909,6 +917,10 @@ async fn test_multiple_transactions_across_blocks() {
     let Some(ctx) = TestContext::new().await else {
         return;
     };
+    if !ctx.dashd.supports_mining {
+        eprintln!("Skipping test (dashd RPC miner not available)");
+        return;
+    }
 
     let (wallet, wallet_id) = ctx.create_wallet();