Skip to content

chore(dx): tighten github skill — issue creation flow + Copilot review docs#80

Merged
x3ek merged 2 commits into
mainfrom
chore/dx-issue-creation-flow
May 16, 2026
Merged

chore(dx): tighten github skill — issue creation flow + Copilot review docs#80
x3ek merged 2 commits into
mainfrom
chore/dx-issue-creation-flow

Conversation

@x3ek
Copy link
Copy Markdown
Contributor

@x3ek x3ek commented May 16, 2026

Summary

Two related tightenings of the github skill, no code changes.

1. Issue creation flow (.claude/skills/github/SKILL.md, CLAUDE.md)

After filing #79 with only labels (no milestone, no type), reshape the creation flow so the agent files complete issues by default:

  • Replace 5 detachable steps with one checklist: title + body + labels + milestone + type.
  • Default to the active milestone (SquishMark 1.0) instead of prompting, so it works in autonomous-mode runs.
  • Add a one-line reinforcement in CLAUDE.md pointing at the skill's full flow.

2. Copilot Code Review docs (.claude/skills/github/references/pull-requests.md)

New section covering how to request a Copilot review and wait for it. Surfaced after I incorrectly reported "no workflow correlates to a Copilot review" — there isn't an Actions run or check-run, but there IS a copilot_work_started timeline event on the PR, performed by app copilot-pull-request-reviewer. The reference now documents:

  • The working request payload (copilot-pull-request-reviewer[bot] with brackets — other variants 422 or get silently dropped).
  • The two-signal wait: copilot_work_started timeline event (work started), then the reviews API (review submitted), then a ~60s lag for inline comments.
  • Reply-to-inline-comment and re-request commands.
  • The fact that new commits don't auto-trigger a re-review.

🤖 Generated with Claude Code

After filing #79 with only labels and getting flagged, tighten the docs so the agent matches the full convention (title + body + labels + milestone + type) by default. Replaces the 'prompt about milestone' step with 'apply the active milestone; only ask if multiple are active' so this works in autonomous-mode runs.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Docs-only update tightening the agent's GitHub issue creation workflow so that new issues are filed with a complete set of metadata (title, body, labels, milestone, and type) by default, rather than as label-only stubs.

Changes:

  • Rewrites the Creation Flow in .claude/skills/github/SKILL.md into a tighter checklist that bundles labels into the initial gh issue create call and adds explicit milestone/type steps with SquishMark 1.0 as the default milestone.
  • Updates CLAUDE.md to point at the github skill's full creation flow and explicitly forbid label-only issues.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
CLAUDE.md One-line reinforcement directing new-issue creation through the github skill's full flow.
.claude/skills/github/SKILL.md Condenses 5-step flow into a checklist requiring title + body + labels + milestone + type, defaulting milestone to SquishMark 1.0.

Add a Copilot Code Review section to references/pull-requests.md covering: the working reviewer identifier (copilot-pull-request-reviewer[bot] with brackets), the two correct waiting signals (copilot_work_started timeline event for 'work started', then the reviews API for 'review submitted'), the ~60s lag before inline comments populate, and how to reply / re-request.

The Copilot reviewer is a GitHub App posting reviews directly — it does NOT produce a workflow run or a check, so gh run list and gh pr checks won't help. The signals live on the issue timeline and reviews APIs.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

@x3ek x3ek changed the title chore(dx): require milestone + type when filing new issues chore(dx): tighten github skill — issue creation flow + Copilot review docs May 16, 2026
@x3ek x3ek merged commit 4545f16 into main May 16, 2026
10 checks passed
@x3ek x3ek deleted the chore/dx-issue-creation-flow branch May 16, 2026 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants