Don't fail seeing a backup refering to non-existent disk#70
Open
ydirson wants to merge 3 commits into
Open
Conversation
alexbrett
reviewed
Oct 24, 2023
Contributor
|
BTW... got the error too this morning. Pretty boring indeed. |
ydirson
force-pushed
the
inexistant-disks
branch
from
7a99335 to
44624db
Compare
freddy77
reviewed
Jun 21, 2024
| backups.append(backup) | ||
| except: | ||
| if not os.path.exists(os.path.join(b.mount_point, '.xen-backup-partition')): | ||
| raise StopIteration() |
Contributor
There was a problem hiding this comment.
I found this raising StopIteration and catching it weird and hard to read. Why not using a try/finally doing the b.umount() in the finally and using continue here?
Contributor
Author
There was a problem hiding this comment.
The lack of break equivalent for try blocks is a problem. I guess return [] here would be suitable enough if we did not have a loop.
I'm quite unsure how to make that more readable.
Contributor
There was a problem hiding this comment.
You are inside a for loop, why not using break and/or continue ? Also, you can put the b.unmount() inside a finally section.
ydirson
force-pushed
the
inexistant-disks
branch
from
44624db to
4897a5f
Compare
Contributor
Author
|
Rebased, and improved the exception logging in patch 2 |
ydirson
force-pushed
the
inexistant-disks
branch
from
4897a5f to
561a17b
Compare
Contributor
Author
|
Dropped the first commit, made unnecessary by #237 |
- it is bad practice to "catch any" - not logging anything just hides information, which can be especially important here as the reason for a try/catch is not obvious (exceptions thrown by XenServerBackup.__init__?) Signed-off-by: Yann Dirson <yann.dirson@vates.fr>
Previous code structure was that of 2 nested if's, with nominal code path being in the positive branch of each if. Adding another condition will bring a need for logging the reason to ignore a backup, but doing that by converting inner `if` to an `elif` chain (arguably the simplest modification) would bring the nominal code path to switch to the negative/last branch of the inner `elif` chain. At the same time, the outer `if` would not seem special enough to deserve it special place (and the cyclomatic complexity). This commit leverages the existing `try:except:` block to switch to an "error out the loop" pattern, where the nominal code path is just linear. Using `StopIteration` may feel like an abuse, but: - it is the only standard `Exception` that is not a `StandardError` or a `Warning`, and defining a new one could seem overkill - the closest alternative would be a `while True` loop and breaking out in both exceptional code paths and at the end of nominal path, where the `break` statements would "stop the iteration" as well Signed-off-by: Yann Dirson <yann.dirson@vates.fr>
…rver#66) Signed-off-by: Yann Dirson <yann.dirson@vates.fr>
ydirson
force-pushed
the
inexistant-disks
branch
from
6cea3a1 to
7ef3e08
Compare
Contributor
Author
|
Rebased, no conflicts. Is there anything holding back this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the various problems seen as part of #66, and then some.
This is a continuation of #67 which got closed when
xs8was destroyed and cannot be reopened (thx github).