Add ssh_no_proxy parameter (via @gaserre to address issue #84)#87
Open
chqr wants to merge 2 commits intoxenserver:masterfrom
Open
Add ssh_no_proxy parameter (via @gaserre to address issue #84)#87chqr wants to merge 2 commits intoxenserver:masterfrom
chqr wants to merge 2 commits intoxenserver:masterfrom
Conversation
If ssh_no_proxy is specified, do not use a proxy (port forwarding) when executing the provision and shutdown steps. The reason to avoid proxying is that the current implementation does not handle ssh disconnects properly. The VNC boot command still uses the proxy.
Contributor
|
@chqr - can you elaborate on the ssh disconnect issues you're referring to? Perhaps we could fix that? |
Author
|
@rdobson thanks for the reply! The discussion in #84 has the background on this PR. The ssh disconnect issues were observed by @gaserre, and were his reason for creating this patch in his fork of packer-builder-xenserver. My team needs this option for a different reason. In the XenServer cluster where we build our Packer vms, the vms use a different vlan than the Xen hosts. It is impossible to connect to the new vm's IP from the Xen host. It is possible, however, for the Packer process to directly connect to the vm. That's why we need to have a way to disable the ssh proxy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Via @gaserre:
If ssh_no_proxy is specified, do not use a proxy (port forwarding)
when executing the provision and shutdown steps.
The reason to avoid proxying is that the current implementation does not
handle ssh disconnects properly.
The VNC boot command still uses the proxy.