Skip to content

Commit ac2a972

Browse files
authored
Merge pull request #115 from RobertZenz/jdbc3resultset-char-datatype-detection
Added detection of the CHAR datatype.
2 parents 4484854 + c80e783 commit ac2a972

2 files changed

Lines changed: 6 additions & 5 deletions

File tree

src/main/java/org/sqlite/jdbc3/JDBC3ResultSet.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -787,7 +787,7 @@ public int getColumnType(int col) throws SQLException {
787787

788788
if (valueType == SQLITE_TEXT || valueType == SQLITE_NULL) {
789789
if ("CHARACTER".equals(typeName) || "NCHAR".equals(typeName) ||
790-
"NATIVE CHARACTER".equals(typeName)) {
790+
"NATIVE CHARACTER".equals(typeName) || "CHAR".equals(typeName)) {
791791
return Types.CHAR;
792792
}
793793

src/test/java/org/sqlite/RSMetaDataTest.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -78,18 +78,18 @@ public void columnTypes() throws SQLException
7878
"col17 CLOB, col18 BLOB, col19 REAL, col20 DOUBLE, " +
7979
"col21 DOUBLE PRECISION, col22 FLOAT, col23 NUMERIC, " +
8080
"col24 DECIMAL(10,5), col25 BOOLEAN, col26 DATE, col27 DATETIME, " +
81-
"col28 TIMESTAMP)"
81+
"col28 TIMESTAMP, col29 CHAR(70))"
8282
);
8383
// insert empty data into table otherwise getColumnType returns null
8484
stat.executeUpdate(
8585
"insert into tbl values (1, 2, 3, 4, 5, 6, 7, 8, 9," +
8686
"'c', 'varchar', 'varying', 'n', 'n','nvarchar', 'text', 'clob'," +
87-
"null, 1.1, 1.2, 1.3, 1.4, 1.5, 1.6, 0, 12345, 123456, 0)");
87+
"null, 1.1, 1.2, 1.3, 1.4, 1.5, 1.6, 0, 12345, 123456, 0, 'char')");
8888
meta = stat.executeQuery(
8989
"select col1, col2, col3, col4, col5, col6, col7, col8, col9, " +
9090
"col10, col11, col12, col13, col14, col15, col16, col17, col18, " +
9191
"col19, col20, col21, col22, col23, col24, col25, col26, col27, " +
92-
"col28, " +
92+
"col28, col29, " +
9393
"cast(col1 as boolean) from tbl"
9494
).getMetaData();
9595

@@ -126,8 +126,9 @@ public void columnTypes() throws SQLException
126126
assertEquals(Types.DATE, meta.getColumnType(27));
127127

128128
assertEquals(Types.TIMESTAMP, meta.getColumnType(28));
129+
assertEquals(Types.CHAR, meta.getColumnType(29));
129130

130-
assertEquals(Types.BOOLEAN, meta.getColumnType(29));
131+
assertEquals(Types.BOOLEAN, meta.getColumnType(30));
131132

132133
assertEquals(10, meta.getPrecision(24));
133134
assertEquals(5, meta.getScale(24));

0 commit comments

Comments
 (0)