Add popover mode to FilterChooser; deprecate PopoverFilterChooser (#4084)#4457
Merged
Conversation
) Folds the popover behavior into FilterChooser as a first-class `popover` mode backed by a single real `select`, replacing the PopoverFilterChooser wrapper's duplicate-control design (two filterChoosers sharing one inputRef, an `omit` hack, and a `disabled` target) that caused all three reported symptoms: - The collapsed trigger now always occupies its space, so surrounding layout no longer shifts when the popover opens. - The trigger's clear and favorites controls respond to a single click rather than first requiring the popover to be opened. Only the interactive instance binds `model.inputRef`, so trigger and content can mount together without contention. The trigger is made non-interactive via react-select `menuIsOpen`/`isSearchable` rather than `disabled`, keeping its clear/favorites affordances live; the expand popover skips opening on clicks that land on those controls. PopoverFilterChooser is now a thin @deprecated alias delegating to `filterChooser({popover: true})`. Admin panels migrated accordingly.
TomTirapani
approved these changes
Jun 30, 2026
TomTirapani
left a comment
TomTirapani
left a comment
Member
There was a problem hiding this comment.
Looks good - great change 👍
Member
Nice pickup on this one, thanks for the improvement! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4084.
Folds the popover behavior into
FilterChooseras a first-classpopovermode backed by a single realselect, replacing thePopoverFilterChooserwrapper's duplicate-control design (twofilterChoosers sharing oneinputRef, anomithack, and adisabledtarget) that was the root cause of all three reported symptoms.What changed
filterChooser({popover: true})renders the control collapsed in-place and expands it into a popover when opened. Newpopover?: boolean | FilterChooserPopoverOptionsprop (position,width).model.inputRef, so the collapsed trigger and expanded content mount together without contention - no moreomit.menuIsOpen/isSearchableinstead ofdisabled, keeping its clear and favorites controls live. The expand popover skips opening on clicks that land on those controls (elemWithin), and favorites is gated so only one menu shows at a time.PopoverFilterChooseris now a thin@deprecatedalias delegating tofilterChooser({popover: true}); to be removed in a future major.Fixes
Migration
ActivityTrackingPanelandRolePanelupdated to the new mode.Verifying behavior in the browser before marking ready for review.