feat: unprintable key code support in xcode plugin

Author: xinnjie

internal/mappings/mapping_config_xcode.go

@@ -11,6 +11,9 @@ import (
 type XcodeMappingConfig struct {
 	EditorActionMapping `yaml:",inline"`
 
+	// The Xcode text action name for Text Key Bindings (e.g., "pageDown:", "deleteBackward:")
+	TextAction string `yaml:"textAction,omitempty"`
+
 	// The Xcode action name (e.g., "moveWordLeft:", "selectWord:")
 	Action string `yaml:"action"`
 	// The command group ID
@@ -65,30 +68,46 @@ func (x *XcodeConfigs) UnmarshalYAML(node *yaml.Node) error {
 }
 
 func checkXcodeDuplicateConfig(mappings map[string]ActionMappingConfig) error {
-	seen := make(map[struct{ Action, CommandID string }]string)
+	seenMenuBindings := make(map[struct{ Action, CommandID string }]string)
+	seenTextBindings := make(map[string]string)
 	dups := make(map[string][]string) // key string -> list of universal action IDs
+
 	for id, mapping := range mappings {
 		for _, xcodeConfig := range mapping.Xcode {
-			if xcodeConfig.Action == "" {
-				continue
-			}
 			// Skip configs that are disabled for import (export-only)
 			if xcodeConfig.DisableImport {
 				continue
 			}
 
-			key := struct{ Action, CommandID string }{xcodeConfig.Action, xcodeConfig.CommandID}
-			if originalID, exists := seen[key]; exists {
-				dupKey := fmt.Sprintf(`{"action":%q,"commandID":%q}`, key.Action, key.CommandID)
-				if _, ok := dups[dupKey]; !ok {
-					dups[dupKey] = []string{originalID}
+			// Check Menu Key Bindings (Action + CommandID)
+			if xcodeConfig.Action != "" {
+				key := struct{ Action, CommandID string }{xcodeConfig.Action, xcodeConfig.CommandID}
+				if originalID, exists := seenMenuBindings[key]; exists {
+					dupKey := fmt.Sprintf(`{"action":%q,"commandID":%q}`, key.Action, key.CommandID)
+					if _, ok := dups[dupKey]; !ok {
+						dups[dupKey] = []string{originalID}
+					}
+					dups[dupKey] = append(dups[dupKey], id)
+				} else {
+					seenMenuBindings[key] = id
+				}
+			}
+
+			// Check Text Key Bindings (TextAction)
+			if xcodeConfig.TextAction != "" {
+				if originalID, exists := seenTextBindings[xcodeConfig.TextAction]; exists {
+					dupKey := fmt.Sprintf(`{"textAction":%q}`, xcodeConfig.TextAction)
+					if _, ok := dups[dupKey]; !ok {
+						dups[dupKey] = []string{originalID}
+					}
+					dups[dupKey] = append(dups[dupKey], id)
+				} else {
+					seenTextBindings[xcodeConfig.TextAction] = id
 				}
-				dups[dupKey] = append(dups[dupKey], id)
-				continue
 			}
-			seen[key] = id
 		}
 	}
+
 	if len(dups) == 0 {
 		return nil
 	}

internal/plugins/xcode/export.go

@@ -83,6 +83,7 @@ func (e *xcodeExporter) Export(
 ) (*pluginapi.PluginExportReport, error) {
 	// Decode existing config for non-destructive merge
 	var existingKeybindings []xcodeKeybinding
+	var existingTextKeybindings xcodeTextKeybinding
 	if opts.ExistingConfig != nil {
 		// Read all content first
 		rawData, err := io.ReadAll(opts.ExistingConfig)
@@ -95,6 +96,7 @@ func (e *xcodeExporter) Export(
 			return nil, fmt.Errorf("failed to decode existing config: %w", err)
 		}
 		existingKeybindings = plistData.MenuKeyBindings.KeyBindings
+		existingTextKeybindings = plistData.TextKeyBindings.KeyBindings
 	}
 
 	var unmanagedKeybindings []xcodeKeybinding
@@ -109,14 +111,22 @@ func (e *xcodeExporter) Export(
 	// Reorder according to base command order if provided
 	finalKeybindings = orderByBaseCommand(finalKeybindings, existingKeybindings)
 
+	// Generate text key bindings
+	finalTextKeybindings := e.generateTextKeyBindings(setting, existingTextKeybindings)
+
 	// Use plist library to generate the XML
 	plistData := xcodeKeybindingsPlist{
 		MenuKeyBindings: menuKeyBindings{
 			KeyBindings: finalKeybindings,
 		},
+		TextKeyBindings: textKeyBindings{
+			KeyBindings: finalTextKeybindings,
+		},
 	}
 
-	if err := plist.NewEncoder(destination).Encode(plistData); err != nil {
+	encoder := plist.NewEncoder(destination)
+	encoder.Indent("\t")
+	if err := encoder.Encode(plistData); err != nil {
 		return nil, fmt.Errorf("failed to write plist XML: %w", err)
 	}
 
@@ -146,6 +156,7 @@ func (e *xcodeExporter) identifyUnmanagedKeybindings(existingKeybindings []xcode
 
 // findMappingByXcodeKeybinding performs reverse lookup to find if an Xcode keybinding
 // corresponds to any action in our mappings.
+// It checks both Action (for Menu Key Bindings) and CommandID.
 func (e *xcodeExporter) findMappingByXcodeKeybinding(kb xcodeKeybinding) *mappings.ActionMappingConfig {
 	for _, mapping := range e.mappingConfig.Mappings {
 		for _, xcodeConfig := range mapping.Xcode {
@@ -230,3 +241,51 @@ func (e *xcodeExporter) mergeKeybindings(managed, unmanaged []xcodeKeybinding) [
 
 	return result
 }
+
+// generateTextKeyBindings generates Xcode Text Key Bindings from KeymapSetting.
+// It merges managed text bindings with existing ones, with managed taking priority.
+func (e *xcodeExporter) generateTextKeyBindings(
+	setting *keymapv1.Keymap,
+	existingTextBindings xcodeTextKeybinding,
+) xcodeTextKeybinding {
+	// Start with existing text bindings or create new map
+	result := make(xcodeTextKeybinding)
+	for k, v := range existingTextBindings {
+		result[k] = v
+	}
+
+	// Generate managed text bindings
+	for _, km := range setting.GetActions() {
+		mapping := e.mappingConfig.Get(km.GetName())
+		if mapping == nil {
+			continue
+		}
+
+		xcodeConfigs := mapping.Xcode
+		if len(xcodeConfigs) == 0 {
+			continue
+		}
+
+		for _, b := range km.GetBindings() {
+			if b == nil {
+				continue
+			}
+			binding := keymap.NewKeyBinding(b)
+			keys, err := formatKeybinding(binding)
+			if err != nil {
+				e.logger.Warn("Skipping text keybinding with un-formattable key", "action", km.GetName(), "error", err)
+				continue
+			}
+
+			for _, xcodeConfig := range xcodeConfigs {
+				if xcodeConfig.TextAction == "" {
+					continue
+				}
+				// Managed text bindings override existing ones with same key
+				result[keys] = xcodeConfig.TextAction
+			}
+		}
+	}
+
+	return result
+}