refactor: cleanup serve command

Author: xinnjie

example/config.yaml

@@ -44,5 +44,4 @@
 # - ONEKEYMAP_TELEMETRY_ENDPOINT -> telemetry.endpoint
 # - ONEKEYMAP_TELEMETRY_HEADERS -> telemetry.headers
 # - ONEKEYMAP_TELEMETRY_INSECURE -> telemetry.insecure
-# - ONEKEYMAP_SERVER_LISTEN -> server.listen
 # - ONEKEYMAP_EDITORS_VSCODE_KEYMAP_PATH -> editors.vscode.keymap_path

internal/cliconfig/config.go

@@ -45,8 +45,6 @@ type Config struct {
 	OneKeyMap string `mapstructure:"onekeymap"`
 	// Telemetry holds OpenTelemetry configuration.
 	Telemetry TelemetryConfig `mapstructure:"telemetry"`
-	// ServerListen is the server listen address (e.g., "tcp://127.0.0.1:50051" or "unix:///tmp/onekeymap.sock").
-	ServerListen string `mapstructure:"server.listen"`
 	// Editors holds configuration for different editors.
 	Editors map[string]EditorConfig `mapstructure:"editors"`
 }
@@ -65,7 +63,6 @@ type Config struct {
 // - ONEKEYMAP_TELEMETRY_ENDPOINT -> telemetry.endpoint (string)
 // - ONEKEYMAP_TELEMETRY_HEADERS -> telemetry.headers (string, "key1=value1,key2=value2")
 // - ONEKEYMAP_TELEMETRY_INSECURE -> telemetry.insecure (bool)
-// - ONEKEYMAP_SERVER_LISTEN -> server.listen (string, e.g. "tcp://127.0.0.1:50051" or "unix:///tmp/onekeymap.sock")
 
 // NewConfig initializes and returns a new Config object.
 // It sets defaults, binds environment variables, reads config files, and unmarshals the result.
@@ -80,7 +77,6 @@ func NewConfig(sandbox bool) (*Config, error) {
 	// Note: We don't set default for telemetry.enabled to detect if it's explicitly configured
 	viper.SetDefault("telemetry.endpoint", telemetryEndpoint)
 	viper.SetDefault("telemetry.headers", telemetryHeaders)
-	viper.SetDefault("server.listen", "")
 
 	// Set environment variable handling
 	viper.SetEnvPrefix("ONEKEYMAP")

internal/cliconfig/update_telemetry_setting_test.go

@@ -20,10 +20,6 @@ telemetry:
   # Can also be enabled with --telemetry flag
   # enabled: false
   endpoint: "test.example.com"
-
-# Other settings
-server:
-  listen: ":8080"
 `
 
 // nolint:gochecknoglobals // TestConfig for testing - all comments case
@@ -83,9 +79,6 @@ telemetry:
   # Can also be enabled with --telemetry flag
   # enabled: false
   endpoint: "test.example.com"
-# Other settings
-server:
-  listen: ":8080"
 `,
 		},
 		{
@@ -110,9 +103,6 @@ telemetry:
   # Can also be enabled with --telemetry flag
   # enabled: false
   endpoint: "test.example.com"
-# Other settings
-server:
-  listen: ":8080"
 `,
 		},
 		{

internal/cmd/dev_generate_base.go

@@ -11,14 +11,14 @@ import (
 	"strings"
 
 	"github.com/spf13/cobra"
-	"github.com/xinnjie/onekeymap-cli/internal/metrics"
 	ij "github.com/xinnjie/onekeymap-cli/internal/plugins/intellij"
 	"github.com/xinnjie/onekeymap-cli/internal/plugins/vscode"
 	"github.com/xinnjie/onekeymap-cli/internal/plugins/zed"
 	"github.com/xinnjie/onekeymap-cli/pkg/api/keymap"
 	"github.com/xinnjie/onekeymap-cli/pkg/api/platform"
 	"github.com/xinnjie/onekeymap-cli/pkg/api/pluginapi"
 	"github.com/xinnjie/onekeymap-cli/pkg/mappings"
+	"github.com/xinnjie/onekeymap-cli/pkg/metrics"
 )
 
 type devGenerateBaseFlags struct {

internal/cmd/root.go

@@ -11,14 +11,14 @@ import (
 	"github.com/spf13/cobra"
 	"github.com/spf13/viper"
 	"github.com/xinnjie/onekeymap-cli/internal/cliconfig"
-	"github.com/xinnjie/onekeymap-cli/internal/metrics"
 	"github.com/xinnjie/onekeymap-cli/internal/updatecheck"
 	"github.com/xinnjie/onekeymap-cli/internal/views"
 	"github.com/xinnjie/onekeymap-cli/pkg/api/exporterapi"
 	"github.com/xinnjie/onekeymap-cli/pkg/api/importerapi"
 	"github.com/xinnjie/onekeymap-cli/pkg/exporter"
 	"github.com/xinnjie/onekeymap-cli/pkg/importer"
 	"github.com/xinnjie/onekeymap-cli/pkg/mappings"
+	"github.com/xinnjie/onekeymap-cli/pkg/metrics"
 	"github.com/xinnjie/onekeymap-cli/pkg/registry"
 	"golang.org/x/term"
 )
@@ -215,7 +215,6 @@ func Execute() {
 	devCmd.AddCommand(NewCmdDevLookup())
 	devCmd.AddCommand(NewCmdDevMapping())
 	rootCmd.AddCommand(NewCmdView())
-	// rootCmd.AddCommand(NewCmdServe(rootFlags))  // TODO: Migrate serve command
 	rootCmd.AddCommand(NewCmdMigrate())
 	rootCmd.AddCommand(NewCmdImport())
 	rootCmd.AddCommand(NewCmdExport())

internal/cmd/serve.go

@@ -12,9 +12,9 @@ import (
 
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
-	"github.com/xinnjie/onekeymap-cli/internal/metrics"
 	"github.com/xinnjie/onekeymap-cli/pkg/api/pluginapi"
 	"github.com/xinnjie/onekeymap-cli/pkg/mappings"
+	"github.com/xinnjie/onekeymap-cli/pkg/metrics"
 )
 
 func TestConfigDetect_Darwin(t *testing.T) {

internal/plugins/intellij/default_config_path_darwin_test.go

@@ -11,12 +11,12 @@ import (
 
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
-	"github.com/xinnjie/onekeymap-cli/internal/metrics"
 	"github.com/xinnjie/onekeymap-cli/pkg/api/keymap"
 	"github.com/xinnjie/onekeymap-cli/pkg/api/keymap/keybinding"
 	"github.com/xinnjie/onekeymap-cli/pkg/api/platform"
 	"github.com/xinnjie/onekeymap-cli/pkg/api/pluginapi"
 	"github.com/xinnjie/onekeymap-cli/pkg/mappings"
+	"github.com/xinnjie/onekeymap-cli/pkg/metrics"
 )
 
 func TestExportIntelliJKeymap(t *testing.T) {

internal/plugins/intellij/export_test.go

@@ -9,11 +9,11 @@ import (
 
 	"github.com/xinnjie/onekeymap-cli/internal/dedup"
 	"github.com/xinnjie/onekeymap-cli/internal/imports"
-	"github.com/xinnjie/onekeymap-cli/internal/metrics"
 	"github.com/xinnjie/onekeymap-cli/pkg/api/keymap"
 	"github.com/xinnjie/onekeymap-cli/pkg/api/keymap/keybinding"
 	"github.com/xinnjie/onekeymap-cli/pkg/api/pluginapi"
 	"github.com/xinnjie/onekeymap-cli/pkg/mappings"
+	"github.com/xinnjie/onekeymap-cli/pkg/metrics"
 )
 
 type intellijImporter struct {

internal/plugins/intellij/import.go

@@ -10,12 +10,12 @@ import (
 
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
-	"github.com/xinnjie/onekeymap-cli/internal/metrics"
 	"github.com/xinnjie/onekeymap-cli/pkg/api/keymap"
 	"github.com/xinnjie/onekeymap-cli/pkg/api/keymap/keybinding"
 	"github.com/xinnjie/onekeymap-cli/pkg/api/platform"
 	"github.com/xinnjie/onekeymap-cli/pkg/api/pluginapi"
 	"github.com/xinnjie/onekeymap-cli/pkg/mappings"
+	"github.com/xinnjie/onekeymap-cli/pkg/metrics"
 )
 
 func TestImportIntelliJKeymap(t *testing.T) {