add more IT

Signed-off-by: xinyual <xinyual@amazon.com>

Author: xinyual

core/src/main/java/org/opensearch/sql/expression/function/jsonUDF/JsonAppendFunctionImpl.java

@@ -68,8 +68,10 @@ public static Object eval(Object... args) throws JsonProcessingException {
       for (String expandedPath : expandedPaths) {
         expands.add(
             expandedPath
-                + ".meaninglessKey"); // We add meaningless Key since calcite json_insert can only
-        // insert when the path point to null
+                + MEANING_LESS_KEY_FOR_APPEND_AND_EXTEND); // We add meaningless Key since calcite
+        // json_insert can only
+        // insert when the path point to null see:
+        // https://github.com/apache/calcite/blob/d96709c4cc7ca962601317d0a70914ad95e306e1/core/src/main/java/org/apache/calcite/runtime/JsonFunctions.java#L737
         expands.add(keys.get(i + 1));
       }
     }

core/src/main/java/org/opensearch/sql/expression/function/jsonUDF/JsonExtendFunctionImpl.java

@@ -67,17 +67,18 @@ public static Object eval(Object... args) throws JsonProcessingException {
           }
         } else if (value instanceof String stringValue) {
           try {
-            List<Object> targetValues = gson.fromJson(stringValue, List.class);
+            List<Object> targetValues =
+                gson.fromJson(stringValue, List.class); // We first try to extend it as an array
             for (Object targetValue : targetValues) {
-              expands.add(expandedPath + ".meaninglessKey");
+              expands.add(expandedPath + MEANING_LESS_KEY_FOR_APPEND_AND_EXTEND);
               expands.add(targetValue);
             }
           } catch (Exception e) {
-            expands.add(expandedPath + ".meaninglessKey");
+            expands.add(expandedPath + MEANING_LESS_KEY_FOR_APPEND_AND_EXTEND);
             expands.add(value);
           }
         } else {
-          expands.add(expandedPath + ".meaninglessKey");
+          expands.add(expandedPath + MEANING_LESS_KEY_FOR_APPEND_AND_EXTEND);
           expands.add(value);
         }
       }

core/src/main/java/org/opensearch/sql/expression/function/jsonUDF/JsonUtils.java

@@ -14,6 +14,7 @@
 public class JsonUtils {
   static ObjectMapper objectMapper = new ObjectMapper();
   public static Gson gson = new Gson();
+  public static String MEANING_LESS_KEY_FOR_APPEND_AND_EXTEND = ".meaningless_key";
 
   /**
    * @param input candidate json path like a.b{}.c{2}
@@ -53,6 +54,12 @@ public static String convertToJsonPath(String input) {
     return sb.toString();
   }
 
+  /**
+   * Transfer the object input to json node
+   *
+   * @param input
+   * @return
+   */
   public static JsonNode convertInputToJsonNode(Object input) {
     try {
       JsonNode root;

integ-test/build.gradle

@@ -448,8 +448,8 @@ integTest {
 
     dependsOn ':opensearch-sql-plugin:bundlePlugin'
     if(getOSFamilyType() != "windows") {
-        //dependsOn startPrometheus
-        //finalizedBy stopPrometheus
+        dependsOn startPrometheus
+        finalizedBy stopPrometheus
     }
 
     // enable calcite codegen in IT

integ-test/src/test/java/org/opensearch/sql/calcite/standalone/CalcitePPLJsonBuiltinFunctionIT.java

@@ -247,6 +247,34 @@ public void testJsonSet() {
     verifyDataRows(actual, rows("{\"a\":[{\"b\":\"3\"},{\"b\":\"3\"}]}"));
   }
 
+  @Test
+  public void testJsonSetWithWrongPath() {
+    JSONObject actual =
+        executeQuery(
+            String.format(
+                "source=%s | eval a =json_set('{\"a\":[{\"b\":1},{\"b\":2}]}', 'a{}.b.d', '3')|"
+                    + " fields a | head 1",
+                TEST_INDEX_PEOPLE2));
+
+    verifySchema(actual, schema("a", "string"));
+
+    verifyDataRows(actual, rows("{\"a\":[{\"b\":1},{\"b\":2}]}"));
+  }
+
+  @Test
+  public void testJsonSetPartialSet() {
+    JSONObject actual =
+        executeQuery(
+            String.format(
+                "source=%s | eval a =json_set('{\"a\":[{\"b\":1},{\"b\":{\"c\": 2}}]}', 'a{}.b.c',"
+                    + " '3')| fields a | head 1",
+                TEST_INDEX_PEOPLE2));
+
+    verifySchema(actual, schema("a", "string"));
+
+    verifyDataRows(actual, rows("{\"a\":[{\"b\":1},{\"b\":{\"c\":\"3\"}}]}"));
+  }
+
   @Test
   public void testJsonDelete() {
     JSONObject actual =