Skip to content

Commit dda896d

Browse files
committed
fix UT and doctest
Signed-off-by: xinyual <xinyual@amazon.com>
1 parent d7904aa commit dda896d

4 files changed

Lines changed: 2 additions & 5 deletions

File tree

docs/user/ppl/cmd/parse.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ PPL query::
4040
|-----------------------+------------|
4141
| amberduke@pyrami.com | pyrami.com |
4242
| hattiebond@netagy.com | netagy.com |
43-
| null | |
43+
| null | null |
4444
| daleadams@boink.com | boink.com |
4545
+-----------------------+------------+
4646

opensearch/src/test/java/org/opensearch/sql/opensearch/executor/OpenSearchExecutionEngineTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,6 @@ void explain_successfully() {
174174
new OpenSearchExecutionEngine(client, protector, new PlanSerializer(null));
175175
Settings settings = mock(Settings.class);
176176
when(settings.getSettingValue(SQL_CURSOR_KEEP_ALIVE)).thenReturn(TimeValue.timeValueMinutes(1));
177-
when(settings.getSettingValue(Settings.Key.SQL_PAGINATION_API_SEARCH_AFTER)).thenReturn(true);
178177

179178
OpenSearchExprValueFactory exprValueFactory = mock(OpenSearchExprValueFactory.class);
180179
final var name = new OpenSearchRequest.IndexName("test");

opensearch/src/test/java/org/opensearch/sql/opensearch/executor/protector/OpenSearchExecutionProtectorTest.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,8 +94,6 @@ public void setup() {
9494

9595
@Test
9696
void test_protect_indexScan() {
97-
when(settings.getSettingValue(Settings.Key.SQL_PAGINATION_API_SEARCH_AFTER)).thenReturn(true);
98-
9997
String indexName = "test";
10098
final int maxResultWindow = 10000;
10199
NamedExpression include = named("age", ref("age", INTEGER));

ppl/src/test/java/org/opensearch/sql/ppl/parser/AstBuilderTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -896,7 +896,7 @@ protected void assertEqual(String query, String expected) {
896896
}
897897

898898
private Node plan(String query) {
899-
AstBuilder astBuilder = new AstBuilder(query);
899+
AstBuilder astBuilder = new AstBuilder(query, settings);
900900
return astBuilder.visit(parser.parse(query));
901901
}
902902

0 commit comments

Comments
 (0)