From 756a3e4294fcf7ee5274a7fafdf8f25d087c8d8f Mon Sep 17 00:00:00 2001
From: Matthew O'Connor <matthew.oconnor@xledger.com>
Date: Tue, 5 Aug 2025 15:50:19 -0600
Subject: [PATCH 1/2] Provide ToImmArray extension methods that take a `Func<T,
 U> select`.

---
 Xledger.Collections.Test/TestImmArray.cs | 11 +++++++
 Xledger.Collections.Test/TestImmSet.cs   |  9 ++++++
 Xledger.Collections/Extensions.cs        | 40 ++++++++++++++++++++++++
 3 files changed, 60 insertions(+)

diff --git a/Xledger.Collections.Test/TestImmArray.cs b/Xledger.Collections.Test/TestImmArray.cs
index 0771ac7..3c6fe71 100644
--- a/Xledger.Collections.Test/TestImmArray.cs
+++ b/Xledger.Collections.Test/TestImmArray.cs
@@ -172,5 +172,16 @@ public void TestSpan() {
     }
 
     public record Employee(int Id, string Name, decimal Salary);
+
+    [Fact]
+    public void TestToImmArrayWithFunc() {
+        var arr = Enumerable.Range(-1, 100).Select(i => $"{i}: {2*i}").ToArray();
+        var imm = Enumerable.Range(-1, 100).ToImmArray(i => $"{i}: {2 * i}");
+        Assert.Equal(arr.Length, imm.Length);
+        Assert.Equal("-1: -2", imm[0]);
+        for (int i = 0; i < imm.Length; ++i) {
+            Assert.Equal(arr[i], imm[i]);
+        }
+    }
 }
 
diff --git a/Xledger.Collections.Test/TestImmSet.cs b/Xledger.Collections.Test/TestImmSet.cs
index ced1dcc..b9a360d 100644
--- a/Xledger.Collections.Test/TestImmSet.cs
+++ b/Xledger.Collections.Test/TestImmSet.cs
@@ -107,6 +107,15 @@ public void TestNoOps() {
         Assert.ThrowsAny<NotSupportedException>(() => iset.Remove(4));
         Assert.ThrowsAny<NotSupportedException>(() => ((System.Collections.ICollection)iset).CopyTo((Array)null, 0));
     }
+
+    [Fact]
+    public void TestSelect() {
+        var imm = Enumerable.Range(-10, 21).ToImmSet(Math.Abs);
+        Assert.Equal(11, imm.Count);
+        for (int i = 0; i < 10; ++i) {
+            Assert.Contains(i, (ISet<int>)imm);
+        }
+    }
 }
 
 
diff --git a/Xledger.Collections/Extensions.cs b/Xledger.Collections/Extensions.cs
index e5caab7..37414e6 100644
--- a/Xledger.Collections/Extensions.cs
+++ b/Xledger.Collections/Extensions.cs
@@ -12,6 +12,16 @@ public static ImmArray<T> ToImmArray<T>(this IEnumerable<T> xs) {
         };
     }
 
+    public static ImmArray<U> ToImmArray<T, U>(this IEnumerable<T> xs, Func<T, U> select) {
+        return xs switch {
+            null => ImmArray<U>.Empty,
+            T[] arr => new ImmArray<U>(ArrayOf(arr.Length, arr, select)),
+            ICollection<T> coll => new ImmArray<U>(ArrayOf(coll.Count, coll, select)),
+            IReadOnlyCollection<T> roColl => new ImmArray<U>(ArrayOf(roColl.Count, roColl, select)),
+            _ => new ImmArray<U>(ArrayOf(xs, select)),
+        };
+    }
+
 #if NET
     public static ImmArray<T> ToImmArray<T>(this ReadOnlySpan<T> xs) {
         return new ImmArray<T>(xs.ToArray());
@@ -26,6 +36,13 @@ public static ImmSet<T> ToImmSet<T>(this IEnumerable<T> xs) {
         };
     }
 
+    public static ImmSet<U> ToImmSet<T, U>(this IEnumerable<T> xs, Func<T, U> select) {
+        return xs switch {
+            null => ImmSet<U>.Empty,
+            _ => new ImmSet<U>(SetOf(xs, select)),
+        };
+    }
+
 #if NET
     public static ImmSet<T> ToImmSet<T>(this ReadOnlySpan<T> xs) {
         return new ImmSet<T>(xs.ToArray());
@@ -64,6 +81,7 @@ Func<T, V> selectVal
             _ => new ImmDict<K, V>(xs.ToDictionary(selectKey, selectVal)),
         };
     }
+
     internal static T[] ArrayOf<T>(T[] arr) {
         return (T[])arr.Clone();
     }
@@ -92,10 +110,32 @@ internal static T[] ArrayOf<T>(IEnumerable<T> xs) {
         return lst.ToArray();
     }
 
+    internal static U[] ArrayOf<T, U>(int n, IEnumerable<T> xs, Func<T, U> f) {
+        var arr = new U[n];
+        var i = 0;
+        foreach (var x in xs) {
+            arr[i] = f(x);
+            ++i;
+        }
+        return arr;
+    }
+
+    internal static U[] ArrayOf<T, U>(IEnumerable<T> xs, Func<T, U> f) {
+        var lst = new List<U>();
+        foreach (var x in xs) {
+            lst.Add(f(x));
+        }
+        return lst.ToArray();
+    }
+
     internal static HashSet<T> SetOf<T>(IEnumerable<T> xs) {
         return new HashSet<T>(xs);
     }
 
+    internal static HashSet<U> SetOf<T, U>(IEnumerable<T> xs, Func<T, U> f) {
+        return new HashSet<U>(xs.Select(f));
+    }
+
     internal static Dictionary<K, V> DictOf<K, V>(IEnumerable<KeyValuePair<K, V>> xs) {
 #if NET6_0_OR_GREATER
         return new Dictionary<K, V>(xs, null);

From 57ef7babf50a810fc880c37f238ad112917acb48 Mon Sep 17 00:00:00 2001
From: Matthew O'Connor <matthew.oconnor@xledger.com>
Date: Tue, 5 Aug 2025 16:15:43 -0600
Subject: [PATCH 2/2] select -> selector

---
 Xledger.Collections/Extensions.cs | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/Xledger.Collections/Extensions.cs b/Xledger.Collections/Extensions.cs
index 37414e6..31338bd 100644
--- a/Xledger.Collections/Extensions.cs
+++ b/Xledger.Collections/Extensions.cs
@@ -12,13 +12,13 @@ public static ImmArray<T> ToImmArray<T>(this IEnumerable<T> xs) {
         };
     }
 
-    public static ImmArray<U> ToImmArray<T, U>(this IEnumerable<T> xs, Func<T, U> select) {
+    public static ImmArray<U> ToImmArray<T, U>(this IEnumerable<T> xs, Func<T, U> selector) {
         return xs switch {
             null => ImmArray<U>.Empty,
-            T[] arr => new ImmArray<U>(ArrayOf(arr.Length, arr, select)),
-            ICollection<T> coll => new ImmArray<U>(ArrayOf(coll.Count, coll, select)),
-            IReadOnlyCollection<T> roColl => new ImmArray<U>(ArrayOf(roColl.Count, roColl, select)),
-            _ => new ImmArray<U>(ArrayOf(xs, select)),
+            T[] arr => new ImmArray<U>(ArrayOf(arr.Length, arr, selector)),
+            ICollection<T> coll => new ImmArray<U>(ArrayOf(coll.Count, coll, selector)),
+            IReadOnlyCollection<T> roColl => new ImmArray<U>(ArrayOf(roColl.Count, roColl, selector)),
+            _ => new ImmArray<U>(ArrayOf(xs, selector)),
         };
     }
 
@@ -36,10 +36,10 @@ public static ImmSet<T> ToImmSet<T>(this IEnumerable<T> xs) {
         };
     }
 
-    public static ImmSet<U> ToImmSet<T, U>(this IEnumerable<T> xs, Func<T, U> select) {
+    public static ImmSet<U> ToImmSet<T, U>(this IEnumerable<T> xs, Func<T, U> selector) {
         return xs switch {
             null => ImmSet<U>.Empty,
-            _ => new ImmSet<U>(SetOf(xs, select)),
+            _ => new ImmSet<U>(SetOf(xs, selector)),
         };
     }