Add build.link_target_with_fullpath policy to attempt to link target with full path

[waruqi]

#7000

[gemini-code-assist]

Summary of Changes

Hello @waruqi, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances Xmake's linking capabilities by introducing a new policy, build.link_target_with_fullpath. This policy, enabled by default, allows the build system to use the full absolute path of target libraries when inheriting links. This change is designed to prevent linking conflicts that can arise when multiple libraries with the same name exist in different directories, ensuring a more reliable and explicit linking process.

Highlights

• New Build Policy: Introduced build.link_target_with_fullpath to control linking behavior, allowing target libraries to be linked using their absolute paths.
• Full Path Linking: When enabled, this policy ensures target libraries are linked with their full paths when inheriting dependencies, which helps resolve potential linking conflicts.
• Toolchain Compatibility: A new utility function can_link_fullpath was added to check if the current toolchain supports linking with full paths before applying the policy.
• Inherit Links Rule Update: The inherit_links rule was modified to integrate the new policy and utility, conditionally using full paths for links and adjusting linkdirs accordingly.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a new policy build.link_target_with_fullpath to control whether to use full paths when linking target dependencies, which is a useful feature for avoiding link conflicts. The implementation is generally good, but I have identified a minor bug in the linker detection logic and a couple of areas where the code could be simplified for better readability and maintainability. My review includes specific suggestions to address these points.

[gemini-code-assist]

The logic here can be simplified for better readability. Also, the call to target:has_tool is missing "ld" from the list of tools to check. This means if the linker is ld, has_tool will return false, which is likely not the intended behavior.

I suggest refactoring this block to fix the bug and make the logic clearer.

        if target:policy("build.link_target_with_fullpath") and target:has_tool("ld", "ld", "gxx", "clangxx", "link") then
            link_filepath = true
        else
            link_filepath = false
        end

[gemini-code-assist]

This if block can be simplified to a direct assignment, since target_utils.can_link_fullpath(target) already returns a boolean value. This makes the code more concise.

            link_filepath = target_utils.can_link_fullpath(target)