Implement logic add_deps with {public = false}#7350
Conversation
Summary of ChangesHello @luadebug, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines Xmake's dependency management by introducing a mechanism to control the transitivity of build flag inheritance. Specifically, it enables users to declare a dependency as non-public, preventing its build flags from propagating further down the dependency chain to indirect dependents. This change enhances modularity and prevents unintended flag pollution in complex projects, ensuring that only direct dependents receive necessary build configurations. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request implements the {public = false} option for add_deps to control transitive dependency inheritance. The core logic change in xmake/core/project/target.lua correctly handles this by checking the public flag for transitive dependencies. The accompanying tests are comprehensive, covering various target kinds and dependency scenarios to ensure the new logic works as expected. I have one suggestion to improve code conciseness in the logic implementation.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request correctly implements the {public = false} option for add_deps, which prevents transitive inheritance of dependency properties like defines and include directories. The core logic change in xmake/core/project/target.lua is sound. The accompanying tests are thorough, covering a variety of target types (header-only, static, shared) and ensuring the new behavior is verified. I have one suggestion to improve the readability of the implementation.
| if t ~= self then | ||
| local deppublic = t:extraconf("deps", dep:name(), "public") or t:extraconf("deps", dep:fullname(), "public") | ||
| if deppublic ~= nil and not deppublic then | ||
| return false |
There was a problem hiding this comment.
This is no different from using {inherit = false}.
The point of this issue is that deps themselves should also have visibility configurations such as private/public.
It does not control whether the visibility of defines/incudedirs is inherited.
In other words, add_deps("xxx", {public = false}) will be a private dependency of the current target, and will not export any of its configuration, including links.
It also does not affect the dependency order of the top-level target compilation.
This is not something that can be easily achieved; there are many details to consider, so I haven't implemented it yet.
2 participants
Resolves: #7079
b.c（直接依赖 — 必须继承）：
#include "*.h"— 证明包含路径继承（否则无法编译）#ifndef HAS_*/#error— 证明 define 是继承的main.c（传递式依赖 — 必须不继承）：
#if __has_include("*.h")/#error— 证明包含路径不继承#ifdef HAS_*/#error— 证明定义不是继承的-Iheaderonly_dir-DHAS_HEADERONLY_A=1-Istatic_static_dir-DHAS_SS_A=2-Ishared_static_dir-DHAS_DS_A=3-Istatic_shared_dir-DHAS_SD_A=4