Issue 149 named foreign keys and views (#332)

* Handle invalid DDL errors for silent false

* Support named foreign keys and view statements

* Document named foreign keys and view statements

* Keep issue 149 changes unreleased

Author: xnuinside

CHANGELOG.md

@@ -11,6 +11,7 @@ The format is based on Keep a Changelog 1.0.0, and this project adheres to Seman
 - None.
 
 ### Fixed
+- MySQL-style `ALTER TABLE ... ADD CONSTRAINT ... FOREIGN KEY constraint_name (...) REFERENCES ...` statements now parse correctly instead of failing on the duplicated foreign key name. `ALTER TABLE ... DROP FOREIGN KEY ...` is also supported, and simple `DROP VIEW` / `CREATE VIEW ... AS ...` statements are now recognized in parser output. https://github.com/xnuinside/simple-ddl-parser/issues/149
 - HQL primitive generic array types like `array<string>` now parse without failing on the closing `>` token. https://github.com/xnuinside/simple-ddl-parser/issues/192
 - `TRUNCATE TABLE schema.table` statements now return the affected table in parser output instead of being skipped. https://github.com/xnuinside/simple-ddl-parser/issues/190
 

README.md

@@ -385,7 +385,7 @@ In output you will have names like 'dbo' and 'TO_Requests', not '[dbo]' and '[TO
 
 - STATEMENTS: PRIMARY KEY, CHECK, FOREIGN KEY in table definitions (in create table();)
 
-- ALTER TABLE STATEMENTS: ADD CHECK (with CONSTRAINT), ADD FOREIGN KEY (with CONSTRAINT), ADD UNIQUE, ADD DEFAULT FOR, ALTER TABLE ONLY, ALTER TABLE IF EXISTS; ALTER .. PRIMARY KEY; ALTER .. USING INDEX TABLESPACE; ALTER .. ADD; ALTER .. MODIFY; ALTER .. ALTER COLUMN; multiple ADD / DROP / MODIFY operations in one statement; etc
+- ALTER TABLE STATEMENTS: ADD CHECK (with CONSTRAINT), ADD FOREIGN KEY (with CONSTRAINT), MySQL-style `ADD CONSTRAINT ... FOREIGN KEY constraint_name (...)`, DROP FOREIGN KEY, ADD UNIQUE, ADD DEFAULT FOR, ALTER TABLE ONLY, ALTER TABLE IF EXISTS; ALTER .. PRIMARY KEY; ALTER .. USING INDEX TABLESPACE; ALTER .. ADD; ALTER .. MODIFY; ALTER .. ALTER COLUMN; multiple ADD / DROP / MODIFY operations in one statement; etc
 
 - PARTITION BY statement
 
@@ -409,6 +409,8 @@ In output you will have names like 'dbo' and 'TO_Requests', not '[dbo]' and '[TO
 
 - CREATE DATABASE [IF NOT EXISTS] + Properties parsing
 
+- DROP VIEW and simple CREATE VIEW ... AS ... statements
+
 ### SparkSQL Dialect statements
 
 - USING
@@ -584,7 +586,9 @@ The format is based on Keep a Changelog 1.0.0, and this project adheres to Seman
 - None.
 
 ### Fixed
-- None.
+- MySQL-style `ALTER TABLE ... ADD CONSTRAINT ... FOREIGN KEY constraint_name (...) REFERENCES ...` statements now parse correctly instead of failing on the duplicated foreign key name. `ALTER TABLE ... DROP FOREIGN KEY ...` is also supported, and simple `DROP VIEW` / `CREATE VIEW ... AS ...` statements are now recognized in parser output. https://github.com/xnuinside/simple-ddl-parser/issues/149
+- HQL primitive generic array types like `array<string>` now parse without failing on the closing `>` token. https://github.com/xnuinside/simple-ddl-parser/issues/192
+- `TRUNCATE TABLE schema.table` statements now return the affected table in parser output instead of being skipped. https://github.com/xnuinside/simple-ddl-parser/issues/190
 
 ## [1.12.0] - 2026-03-27
 ### Added

simple_ddl_parser/dialects/sql.py

@@ -878,6 +878,7 @@ class AlterTable:
     def p_expression_alter(self, p: List) -> None:
         """expr : alter_foreign ref
         | alter_drop_column
+        | alter_drop_foreign
         | alter_check
         | alter_unique
         | alter_default
@@ -915,6 +916,16 @@ def p_alter_drop_column(self, p: List) -> None:
             p[0]["columns_to_drop"] = []
         p[0]["columns_to_drop"].append(p_list[-1])
 
+    def p_alter_drop_foreign(self, p: List) -> None:
+        """alter_drop_foreign : alt_table DROP FOREIGN KEY id
+        | alter_drop_foreign COMMA DROP FOREIGN KEY id
+        """
+        p[0] = p[1]
+        p_list = list(p)
+        if not p[0].get("foreign_keys_to_drop"):
+            p[0]["foreign_keys_to_drop"] = []
+        p[0]["foreign_keys_to_drop"].append(p_list[-1])
+
     def p_alter_rename_column(self, p: List) -> None:
         """alter_rename_column : alt_table RENAME COLUMN id id id"""
         p[0] = p[1]
@@ -2055,9 +2066,10 @@ def p_index_pid(self, p: List) -> None:
     def p_foreign(self, p):
         # todo: need to redone id lists
         """foreign : FOREIGN KEY LP pid RP
+        | FOREIGN KEY id LP pid RP
         | FOREIGN KEY"""
         p_list = remove_par(list(p))
-        if len(p_list) == 4:
+        if isinstance(p_list[-1], list):
             columns = p_list[-1]
             p[0] = columns
 

simple_ddl_parser/output/base_data.py

@@ -262,6 +262,10 @@ def append_statement_information_to_table(self, statement: Dict) -> None:
             self.alter_rename_columns(statement)
         elif "columns_to_drop" in statement:
             self.alter_drop_columns(statement)
+        elif "foreign_keys_to_drop" in statement:
+            if not self.alter.get("foreign_keys_to_drop"):
+                self.alter["foreign_keys_to_drop"] = []
+            self.alter["foreign_keys_to_drop"].extend(statement["foreign_keys_to_drop"])
         elif "columns_to_modify" in statement:
             self.alter_modify_columns(statement)
         elif "check" in statement:

simple_ddl_parser/output/core.py

@@ -102,6 +102,8 @@ def group_by_type_result(self) -> None:
             "sequences": [],
             "domains": [],
             "schemas": [],
+            "views": [],
+            "drop_views": [],
             "ddl_properties": [],
             "comments": [],
             "comment_on": [],
@@ -112,6 +114,8 @@ def group_by_type_result(self) -> None:
             "type_name": "types",
             "domain_name": "domains",
             "schema_name": "schemas",
+            "view_name": "views",
+            "drop_view_name": "drop_views",
             "tablespace_name": "tablespaces",
             "database_name": "databases",
             "value": "ddl_properties",
@@ -134,6 +138,10 @@ def group_by_type_result(self) -> None:
             del result_as_dict["comments"]
         if not result_as_dict["comment_on"]:
             del result_as_dict["comment_on"]
+        if not result_as_dict["views"]:
+            del result_as_dict["views"]
+        if not result_as_dict["drop_views"]:
+            del result_as_dict["drop_views"]
 
         self.final_result = result_as_dict
 

simple_ddl_parser/parser.py

@@ -39,6 +39,28 @@
     flags=re.IGNORECASE | re.DOTALL | re.VERBOSE,
 )
 
+CREATE_VIEW_RE = re.compile(
+    r"""
+    ^\s*CREATE\s+
+    (?P<replace>OR\s+REPLACE\s+)?
+    VIEW\s+
+    (?P<target>[^\s(]+)
+    \s+AS\s+
+    (?P<definition>.+?)
+    \s*$
+    """,
+    flags=re.IGNORECASE | re.DOTALL | re.VERBOSE,
+)
+
+DROP_VIEW_RE = re.compile(
+    r"""
+    ^\s*DROP\s+VIEW\s+
+    (?P<target>[^\s;]+)
+    \s*$
+    """,
+    flags=re.IGNORECASE | re.DOTALL | re.VERBOSE,
+)
+
 
 def set_logging_config(
     log_level: Union[str, int], log_file: Optional[str] = None
@@ -427,6 +449,27 @@ def parse_create_table_as_select_statement(self, statement: str) -> Optional[Dic
             }
         }
 
+    def parse_create_view_statement(self, statement: str) -> Optional[Dict]:
+        match = CREATE_VIEW_RE.match(statement)
+        if not match:
+            return None
+
+        schema, view_name = self.split_table_identifier(match.group("target"))
+        return {
+            "schema": schema,
+            "view_name": view_name,
+            "definition": match.group("definition").strip(),
+            "replace": bool(match.group("replace")),
+        }
+
+    def parse_drop_view_statement(self, statement: str) -> Optional[Dict]:
+        match = DROP_VIEW_RE.match(statement)
+        if not match:
+            return None
+
+        schema, view_name = self.split_table_identifier(match.group("target"))
+        return {"schema": schema, "drop_view_name": view_name}
+
     @staticmethod
     def clone_create_table_as_select_columns(
         source_table: Dict, select_columns: Union[str, List[Dict[str, str]]]
@@ -585,6 +628,14 @@ def parse_statement(self) -> None:
         if create_table_as_select_statement:
             self.tables.append(create_table_as_select_statement)
             return
+        create_view_statement = self.parse_create_view_statement(self.statement)
+        if create_view_statement:
+            self.tables.append(create_view_statement)
+            return
+        drop_view_statement = self.parse_drop_view_statement(self.statement)
+        if drop_view_statement:
+            self.tables.append(drop_view_statement)
+            return
         _parse_result = yacc.parse(self.statement)
         if _parse_result:
             if (

simple_ddl_parser/parsetab.py

@@ -35,6 +35,74 @@ def test_silent_false_flag():
         assert "Unknown statement" in e.value[1]
 
 
+def test_silent_false_mysql_named_foreign_key_in_alter():
+    ddl = """
+    CREATE TABLE parent (
+        id int PRIMARY KEY
+    );
+
+    CREATE TABLE child (
+        parent_id int
+    );
+
+    ALTER TABLE child ADD CONSTRAINT fk_child_parent FOREIGN KEY fk_child_parent (parent_id) REFERENCES parent (id);
+    """
+
+    result = DDLParser(ddl, silent=False).run(output_mode="mysql")
+
+    assert result[1]["table_name"] == "child"
+    assert result[1]["alter"]["columns"] == [
+        {
+            "name": "parent_id",
+            "constraint_name": "fk_child_parent",
+            "references": {
+                "column": "id",
+                "table": "parent",
+                "schema": None,
+                "on_update": None,
+                "on_delete": None,
+                "deferrable_initially": None,
+            },
+        }
+    ]
+
+
+def test_create_and_drop_view_statements():
+    ddl = """
+    DROP VIEW reporting.user_ip_address_view;
+    CREATE VIEW reporting.user_ip_address_view AS SELECT id, name FROM users;
+    """
+
+    result = DDLParser(ddl, silent=False).run(group_by_type=True)
+
+    assert result["drop_views"] == [
+        {"schema": "reporting", "drop_view_name": "user_ip_address_view"}
+    ]
+    assert result["views"] == [
+        {
+            "schema": "reporting",
+            "view_name": "user_ip_address_view",
+            "definition": "SELECT id ,  name FROM users",
+            "replace": False,
+        }
+    ]
+
+
+def test_alter_drop_foreign_key_statement():
+    ddl = """
+    CREATE TABLE child (
+        parent_id int
+    );
+
+    ALTER TABLE child DROP FOREIGN KEY fk_child_parent;
+    """
+
+    result = DDLParser(ddl, silent=False).run(output_mode="mysql")
+
+    assert result[0]["table_name"] == "child"
+    assert result[0]["alter"]["foreign_keys_to_drop"] == ["fk_child_parent"]
+
+
 def test_flag_normalize_names():
     ddl = (
         ddl

tests/non_statement_tests/test_common.py

@@ -84,6 +84,33 @@ def test_parse_from_file_one_table():
     )
 
 
+def test_parse_from_file_mysql_named_foreign_key_with_silent_false(tmp_path):
+    ddl_file = tmp_path / "named_fk.sql"
+    ddl_file.write_text(
+        """
+        CREATE TABLE parent (
+            id int PRIMARY KEY
+        );
+
+        CREATE TABLE child (
+            parent_id int
+        );
+
+        ALTER TABLE child ADD CONSTRAINT fk_child_parent FOREIGN KEY fk_child_parent (parent_id) REFERENCES parent (id);
+        """,
+        encoding="utf-8",
+    )
+
+    result = parse_from_file(
+        str(ddl_file),
+        parser_settings={"silent": False},
+        output_mode="mysql",
+    )
+
+    assert result[1]["table_name"] == "child"
+    assert result[1]["alter"]["columns"][0]["constraint_name"] == "fk_child_parent"
+
+
 def test_parse_from_file_two_statements():
     expected = [
         {