Merge pull request #27 from lucasgl/master

xoofx · web-flow · commit 1cc2ab3eda49 · 2023-10-05T09:13:52.000+02:00
Fix read string bigger than 128 bytes from Stream.
diff --git a/src/LibObjectFile/ObjectFileStreamExtensions.cs b/src/LibObjectFile/ObjectFileStreamExtensions.cs
@@ -60,7 +60,7 @@ public static string ReadStringUTF8NullTerminated(this Stream stream)
                         break;
                     }
 
-                    if (textLength > buffer.Length)
+                    if (textLength >= buffer.Length)
                     {
                         var newBuffer = ArrayPool<byte>.Shared.Rent((int)textLength * 2);
                         Array.Copy(buffer, 0, newBuffer, 0, buffer.Length);

Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ public static string ReadStringUTF8NullTerminated(this Stream stream)`
`60`	`60`	`break;`
`61`	`61`	`}`
`62`	`62`
`63`		`- if (textLength > buffer.Length)`
	`63`	`+ if (textLength >= buffer.Length)`
`64`	`64`	`{`
`65`	`65`	`var newBuffer = ArrayPool<byte>.Shared.Rent((int)textLength * 2);`
`66`	`66`	`Array.Copy(buffer, 0, newBuffer, 0, buffer.Length);`