Add ByPKCE::SUPPORTED

Author: thekid

src/main/php/web/auth/oauth/ByPKCE.class.php

@@ -4,6 +4,8 @@
 
 /** @test web.auth.unittest.ByPKCETest */
 class ByPKCE extends Credentials {
+  const SUPPORTED= ['S256', 'plain'];
+
   private $challenge, $method;
 
   /**
@@ -19,13 +21,12 @@ public function __construct($clientId, $method) {
 
     if ('S256' === $method) {
       $this->challenge= fn($verifier) => JWT::encode(hash('sha256', $verifier, true));
-      $this->method= 'S256';
     } else if ('plain' === $method) {
       $this->challenge= fn($verifier) => $verifier;
-      $this->method= 'plain';
     } else {
-      throw new IllegalArgumentException('Unsupported method '.$method);
+      throw new IllegalArgumentException('Unsupported method '.$method.', expected one of ['.implode(', ', self::SUPPORTED).']');
     }
+    $this->method= $method;
   }
 
   /** @return string */

src/test/php/web/auth/unittest/ByPKCETest.class.php

@@ -14,7 +14,7 @@ private function challenges() {
     yield ['plain', 'test-challenge'];
   }
 
-  #[Test, Values(['S256', 'plain'])]
+  #[Test, Values(ByPKCE::SUPPORTED)]
   public function can_create_with($method) {
     new ByPKCE(self::CLIENT_ID, $method);
   }