Ensure the output stream is always closed when it goes out of scope

Author: thekid

ChangeLog.md

@@ -5,6 +5,8 @@ Web change log
 
 ## 3.11.0 / 2023-12-02
 
+* Ensured the output stream is always closed when it goes out of scope
+  (@thekid)
 * Removed superfluous layer of output buffering in development webserver
   (@thekid)
 * Merged PR #105: Implement `WriteChunks::flush()` to use for explicitely

src/main/php/web/io/Output.class.php

@@ -52,4 +52,9 @@ public function close() {
     $this->finish();
     $this->closed= true;
   }
+
+  /** Ensures `close()` is called */
+  public function __destruct() {
+    $this->close();
+  }
 }

src/test/php/web/unittest/io/OutputTest.class.php

@@ -51,4 +51,19 @@ public function finish() { $this->finished++; }
 
     Assert::equals(1, $out->finished);
   }
+
+  #[Test]
+  public function destructor_calls_finish() {
+    $finished= 0;
+    $out= new class($finished) extends Output {
+      private $finished;
+      public function __construct(&$finished) { $this->finished= &$finished; }
+      public function begin($status, $message, $headers) { }
+      public function write($bytes) { }
+      public function finish() { $this->finished++; }
+    };
+    $out= null;
+
+    Assert::equals(1, $finished);
+  }
 }