refactor: replace manual slice iteration with slices.Backward for improved readability

Author: juicycleff

health/watch_test.go

@@ -2,6 +2,7 @@ package health
 
 import (
 	"context"
+	"slices"
 	"sync"
 	"testing"
 	"time"
@@ -224,9 +225,9 @@ func (s *fakeStore) GetLatestResult(_ context.Context, _ string, checkID id.ID)
 	s.mu.Lock()
 	defer s.mu.Unlock()
 
-	for i := len(s.results) - 1; i >= 0; i-- {
-		if s.results[i].CheckID == checkID {
-			return s.results[i], nil
+	for _, r := range slices.Backward(s.results) {
+		if r.CheckID == checkID {
+			return r, nil
 		}
 	}
 

metrics/service_impl.go

@@ -65,7 +65,7 @@ func (s *service) Track(instanceID id.ID) {
 		s.rings[key] = newRingBuffer(s.cfg.RetentionCapacity)
 	}
 
-	ctx, cancel := context.WithCancel(context.Background())
+	ctx, cancel := context.WithCancel(context.Background()) //nolint:gosec // cancel is retained in s.pollers and invoked by Untrack
 	s.pollers[key] = cancel
 	s.mu.Unlock()
 

store/memory/health.go

@@ -3,6 +3,7 @@ package memory
 import (
 	"context"
 	"fmt"
+	"slices"
 
 	ctrlplane "github.com/xraph/ctrlplane"
 	"github.com/xraph/ctrlplane/health"
@@ -146,9 +147,9 @@ func (s *Store) GetLatestResult(_ context.Context, tenantID string, checkID id.I
 		return nil, fmt.Errorf("%w: no results for check %s", ctrlplane.ErrNotFound, key)
 	}
 
-	for i := len(results) - 1; i >= 0; i-- {
-		if results[i].TenantID == tenantID {
-			clone := results[i]
+	for _, r := range slices.Backward(results) {
+		if r.TenantID == tenantID {
+			clone := r
 
 			return &clone, nil
 		}

store/memory/telemetry.go

@@ -3,6 +3,7 @@ package memory
 import (
 	"context"
 	"fmt"
+	"slices"
 
 	ctrlplane "github.com/xraph/ctrlplane"
 	"github.com/xraph/ctrlplane/id"
@@ -160,8 +161,7 @@ func (s *Store) GetLatestResourceSnapshot(_ context.Context, tenantID string, in
 
 	instKey := idStr(instanceID)
 
-	for i := len(s.resourceSnapshots) - 1; i >= 0; i-- {
-		snap := s.resourceSnapshots[i]
+	for _, snap := range slices.Backward(s.resourceSnapshots) {
 		if idStr(snap.InstanceID) == instKey && snap.TenantID == tenantID {
 			return &snap, nil
 		}