Feedback

Author: xrmx

opamp/opentelemetry-opamp-client/MANIFEST.rst

@@ -16,7 +16,7 @@
 OpenTelemetry Python - OpAMP client
 -----------------------------------
 
-This package provides a bunch of classes that can be used by OpenTelemetry distributions implementers
+This package provides a bunch of classes that can be used by OpenTelemetry distributions implementors
 to implement remote config support via the `OpAMP protocol`_.
 
 The client implements the following capabilities:

opamp/opentelemetry-opamp-client/src/opentelemetry/_opamp/__init__.py

@@ -158,7 +158,7 @@ def send(
 
     def _run_scheduler(self) -> None:
         """
-        After me made a connection periodically enqueue “heartbeat” jobs until stop is signaled.
+        After we made a connection, periodically enqueue “heartbeat” jobs until stop is signaled.
         """
         while not self._stop.wait(self._interval):
             if self._schedule:
@@ -240,16 +240,16 @@ def stop(self) -> None:
 
         # Before exiting send signal the server we are disconnecting to free our resources
         # This is not required by the spec but is helpful in practice
-        logger.debug("Stopping OpAMPClient: sending AgentDisconnect")
+        logger.debug("Stopping OpAMPAgent: sending AgentDisconnect")
         payload = self._client.build_agent_disconnect_message()
         try:
             self._client.send(payload)
         except Exception:  # pylint: disable=broad-exception-caught
             logger.debug(
-                "Stopping OpAMPClient: failed to send AgentDisconnect message"
+                "Stopping OpAMPAgent: failed to send AgentDisconnect message"
             )
 
-        logger.debug("Stopping OpAMPClient: cancelling jobs")
+        logger.debug("Stopping OpAMPAgent: cancelling jobs")
         # Clear pending jobs
         while True:
             try:
@@ -265,12 +265,12 @@ def stop(self) -> None:
             self._worker.join()
         except RuntimeError as exc:
             logger.warning(
-                "Stopping OpAMPClient: worker thread failed to join %s", exc
+                "Stopping OpAMPAgent: worker thread failed to join %s", exc
             )
         try:
             self._scheduler.join()
         except RuntimeError as exc:
             logger.warning(
-                "Stopping OpAMPClient: scheduler thread failed to join %s", exc
+                "Stopping OpAMPAgent: scheduler thread failed to join %s", exc
             )
-        logger.debug("OpAMPClient stopped")
+        logger.debug("OpAMPAgent stopped")