Skip to content

Commit fdc3b15

Browse files
xrmxherin049
andauthored
Apply suggestions from code review
Co-authored-by: Lukas Hering <40302054+herin049@users.noreply.github.com>
1 parent 3dbdef8 commit fdc3b15

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

  • instrumentation/opentelemetry-instrumentation-urllib/src/opentelemetry/instrumentation/urllib

instrumentation/opentelemetry-instrumentation-urllib/src/opentelemetry/instrumentation/urllib/__init__.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ def response_hook(span: Span, request: Request, response: HTTPResponse):
9494
9595
will extract ``content-type`` and ``custom_request_header`` from the request headers and add them as span attributes.
9696
97-
Request header names in aiohttp are case-insensitive. So, giving the header name as ``CUStom-Header`` in the environment
97+
Request header names in urllib are case-insensitive. So, giving the header name as ``CUStom-Header`` in the environment
9898
variable will capture the header named ``custom-header``.
9999
100100
Regular expressions may also be used to match multiple headers that correspond to the given pattern. For example:
@@ -128,7 +128,7 @@ def response_hook(span: Span, request: Request, response: HTTPResponse):
128128
129129
will extract ``content-type`` and ``custom_response_header`` from the response headers and add them as span attributes.
130130
131-
Response header names in aiohttp are case-insensitive. So, giving the header name as ``CUStom-Header`` in the environment
131+
Response header names in urllib are case-insensitive. So, giving the header name as ``CUStom-Header`` in the environment
132132
variable will capture the header named ``custom-header``.
133133
134134
Regular expressions may also be used to match multiple headers that correspond to the given pattern. For example:
@@ -168,8 +168,6 @@ def response_hook(span: Span, request: Request, response: HTTPResponse):
168168
Note:
169169
The environment variable names used to capture HTTP headers are still experimental, and thus are subject to change.
170170
171-
172-
173171
API
174172
---
175173
"""

0 commit comments

Comments
 (0)