Fix cpython.gc metrics to use semantic convention attribute names#4
Draft
Fix cpython.gc metrics to use semantic convention attribute names#4
Conversation
- Import CPYTHON_GC_GENERATION from semantic conventions - Replace "generation" with CPYTHON_GC_GENERATION constant - Change generation values from strings to integers (0, 1, 2) - Update tests to use correct attribute name "cpython.gc.generation" Co-authored-by: xrmx <12932+xrmx@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix violations in opentelemetry-instrumentation-system-metrics
Fix cpython.gc metrics to use semantic convention attribute names
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The cpython.gc metrics (
collections,collected_objects,uncollectable_objects) were using non-namespaced attribute name"generation"with string values, violating semantic conventions which require"cpython.gc.generation"with integer values.Type of change
Changes
CPYTHON_GC_GENERATIONfromopentelemetry.semconv._incubating.attributes.cpython_attributes"generation"toCPYTHON_GC_GENERATIONconstant in:_get_runtime_gc_collections()_get_runtime_gc_collected_objects()_get_runtime_gc_uncollectable_objects()str(index)toindexfor proper integer typing (0, 1, 2)Before:
After:
How Has This Been Tested?
Does This PR Require a Core Repo Change?
Checklist:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.